-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #23609: Add max fermata time stretch up to 10000%. #24050
fix #23609: Add max fermata time stretch up to 10000%. #24050
Conversation
What is your username on MuseScore.org? |
@cbjeukendrup "chilkasidehus" this is my username. |
@@ -53,7 +53,7 @@ ExpandableBlank { | |||
|
|||
step: 1 | |||
decimals: 0 | |||
maxValue: 400 | |||
maxValue: 10000 | |||
minValue: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While at it we may want to reduce minValue
to 1
, as that's the lowest value that has an effect.
See #23609 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct me if I am wrong , so 0% has the same effect as 100% and for 1% to 99 % is kind of first forward or skip the note, so if we set min value to 100% then, Is this solution is feasible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-99 shortens the duration, 0 and 100 leave the normal duration, >100 lengthens the duration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and IMHO 0 doing nothing (or rather the same as 100) seems a bug, disallowing 0 is one way to fix it
Then again 0 might be seen as disabling the fermata effect, if so it isn't a bug.
@cbjeukendrup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make the most sense to set the min to 100 (which does nothing), I'm not sure what the use-case of a fermata producing faster playback is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also an approach... But I learned that the duration of a fermata is defined by the community conductor and by the conductor alone, and as such might be shorter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should i set min value to 100% as of now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please!
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
Resolves: #23609