New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove repeat param from log message #3240

Open

mawen12 wants to merge 1 commit into mybatis:master from mawen12:bugfix-repeat-log-param

mawen12 commented Sep 20, 2024

Hi, I have found the method org.apache.ibatis.io.VFS#getMethod which log message contains repeat param.

protected static Method getMethod(Class<?> clazz, String methodName, Class<?>... parameterTypes) {
  ...
  try {
    ...
  } catch (SecurityException e) {
    ...
  } catch (NoSuchMethodException e) {
    // repeat methodName in log message
    log.error("Method not found " + clazz.getName() + "." + methodName + "." + methodName + ".  Cause: " + e);
    return null;
  }
}

If you run the unit class org.apache.ibatis.io.VFSTest#getNotExistMethod, the console will show the log message.

Method not found org.apache.ibatis.io.VFS.listXxx.listXxx.


          remove repeat methodName from log message

762ea0f

hazendaz approved these changes

View reviewed changes

coveralls commented Sep 20, 2024

coverage: 87.153%. remained the same
when pulling 762ea0f on mawen12:bugfix-repeat-log-param
into 42b7faf on mybatis:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet