Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for China KingSoft Cloud Provider #1521

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

alchu4n
Copy link

@alchu4n alchu4n commented Apr 4, 2023

Description

I have added the necessary code to support Kingsoft Cloud Services, enabling the project to support a wider range of cloud services. This will enhance the functionality of the project and make it more versatile.

Type of change

Select the relevant option(s):

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@x4v13r64 x4v13r64 self-requested a review April 10, 2023 08:22
Copy link
Collaborator

@x4v13r64 x4v13r64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformatting the whole code base makes it extremely tedious to review a PR that includes significant changes. Please open a PR that includes the feature you're trying to add. If you have strong feelings about code formatting, feel free to also open another PR for that!

@liyun-li
Copy link
Collaborator

@alchu4n please see comment above

@liyun-li liyun-li added the enhancement New feature or request label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants