Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Key Vault Private Endpoint Check #1553

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ncc-akis
Copy link
Contributor

@ncc-akis ncc-akis commented Jul 3, 2023

Description

New rule to measure compliance against 8.7 Key Vaults Not Using Private Endpoint Connections in CIS Azure Foundations Benchmark v2.0.0.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3caf861) 20.52% compared to head (1c15d19) 20.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1553      +/-   ##
===========================================
- Coverage    20.52%   20.51%   -0.01%     
===========================================
  Files          384      384              
  Lines        13038    13044       +6     
===========================================
  Hits          2676     2676              
- Misses       10362    10368       +6     
Impacted Files Coverage Δ
...Suite/providers/azure/resources/keyvault/vaults.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant