Bump hsqldb from 2.3.2 to 2.7.1 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps hsqldb from 2.3.2 to 2.7.1. --- updated-dependencies: - dependency-name: org.hsqldb:hsqldb dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
|
I am testing this PR and have 2 questions:
|
|
Please see my comment on the issue. There is an additional pom argument indicating jdk8 if you look at the link I put |
Ah yes I forgot to mention this. I did try adding the jdk8 argument following the suggestion, but it failed at runtime... |
|
You'll have to search for all the pom files and add it to each block that has hsqldb. There are like 4 or 5 that import hsqldb. |
|
If you look at the error the 55 refers to Java 11 so that tells us that some references were missed. |
|
Sorry for the fragmented comments, since you were working on this I was answering from my phone trying to give some clues. I would create a new branch for the hsqldb change since we can't use this dependabot PR. We need to update the pom files to tell it to pull in the Java 8 version of the hsql library. If you do a search for hsql.version you should locate I think 5 pom.xml files that reference it. Wherever it pulls it in, you will need to update to tell it to use the jdk8 by adding the xml tag jdk8. |
These tables are created automatically. We can use the latest, we just have to update the tag to pull in the java 8 version of the library wherever it's referenced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps hsqldb from 2.3.2 to 2.7.1.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.