Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeserver version to latest #138

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Apr 17, 2024

Update codeserver version from v4.5.1 to v4.23.1

Reference Issues or PRs

close #136

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Update codeserver version from v4.5.1 to v4.23.1
@marcelovilla
Copy link
Member

Thanks @viniciusdc!

@marcelovilla marcelovilla merged commit 25697f1 into main Apr 18, 2024
11 checks passed
@marcelovilla marcelovilla deleted the bump-codeserver-version branch April 18, 2024 14:51
@krassowski
Copy link
Member

Worth testing this one solidly as I see some upstream reports that vscode-binder that we use:

- git+https://github.com/betatim/vscode-binder

does not work with code-server 4.10.1 and newer (betatim/vscode-binder#38). Or do we use it only to get the vscode icon?

@marcelovilla
Copy link
Member

@krassowski thanks for the heads up. Code server seems to be working fine but I'm not sure what we use vscode-binder for.

@viniciusdc do you know?

@dharhas
Copy link
Member

dharhas commented Apr 18, 2024

We should probably be shifting to the code-server icon instead of the microsoft vscode icon if that is all it is used for. If we don't know what it is used for then we should remove it and find out that way.

@marcelovilla
Copy link
Member

@dharhas I've added nebari-dev/nebari/#2417 to track this. I can transfer it to this repo if it makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code-server?
4 participants