Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore deleted wallet when ignore duplicate script. #3220

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Aug 2, 2024

@yanguoyu yanguoyu changed the title fix: Ignore delete wallet when ignore duplicate script. fix: Ignore deleted wallet when ignore duplicate script. Aug 2, 2024
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 3, 2024

/package
Packaging for test is done in 10224423251. @yanguoyu

@Keith-CY
Copy link
Collaborator

Keith-CY commented Aug 4, 2024

I didn't get the connection between ignore deleted wallet when ignore duplicate script and 3.In Windows , set start block number is not effective. which is mentioned at Magickbase/neuron-public-issues#417 (comment)

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 4, 2024

I didn't get the connection between ignore deleted wallet when ignore duplicate script and 3.In Windows , set start block number is not effective. which is mentioned at Magickbase/neuron-public-issues#417 (comment)

When finding the duplicate script that belongs to the deleted wallet the new wallet script will not save to the DB at https://github.com/nervosnetwork/neuron/pull/3220/files#diff-da1daa9d927e16165a0cf5cd378178bb7e100c4251d54a4f76f0c5437c5ac9e4L25, then the synced block number will not increase.

@yanguoyu yanguoyu added this pull request to the merge queue Aug 5, 2024
Merged via the queue into nervosnetwork:develop with commit b8ba97b Aug 5, 2024
10 checks passed
@yanguoyu yanguoyu deleted the fix-light-sync branch August 5, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression bugs
4 participants