Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support load env from env file. #3226

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Aug 7, 2024

If we have set the env that includes scripts info, use the env value to replace the lumos config.

@yanguoyu yanguoyu marked this pull request as ready for review August 13, 2024 00:16
@yanguoyu
Copy link
Collaborator Author

@Keith-CY @homura @devchenyan please have a review

@homura
Copy link
Collaborator

homura commented Aug 13, 2024

Is the PR created to allow Neuron to work with a network that isn't mainnet or testnet?

@yanguoyu
Copy link
Collaborator Author

Is the PR created to allow Neuron to work with a network that isn't mainnet or testnet?

That's it, For example, #3026 this PR uses devnet.

@homura
Copy link
Collaborator

homura commented Aug 13, 2024

That's it, For example, #3026 this PR uses devnet.

It would be helpful to provide a comment or documentation explaining how to utilize a devnet by overriding the env variables

If we have set the env that includes scripts info, use the env value to replace the lumos config.
@Keith-CY Keith-CY added this pull request to the merge queue Aug 14, 2024
Merged via the queue into nervosnetwork:develop with commit e9eab5e Aug 14, 2024
10 checks passed
@yanguoyu yanguoyu deleted the feat-support-load-env branch August 14, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants