Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients/, common/, drivers/: refactor debug/log strerror to helper funcs #2631

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

clients/, common/, drivers/: refactor debug/log strerror to helper funcs #2631

wants to merge 3 commits into from
+46 −71

Conversation

desertwitch
Copy link
Contributor

@desertwitch desertwitch commented Sep 15, 2024 •
edited
Loading

had some time to kill on public transportation and did some more detective work, refactors all found occurrences of non-specific strerror functions into their respective helper functions upslog_with_errno() and upsdebug_with_errno()

addresses and possibly fixes #2396

@desertwitch
Copy link
Contributor Author

desertwitch commented Sep 15, 2024 •
edited
Loading

(8f10093) Whoops, missed that %s, interesting my system did not complain...

desertwitch
desertwitch commented Sep 15, 2024
View reviewed changes
common/common.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use upsdebug_with_errno() instead of a few cases calling upsdebugx(..., errno, strerror()) explicitly
1 participant
@desertwitch