Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of multi-columns descriptions #2201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Koc
Copy link
Collaborator

@Koc Koc commented Jun 9, 2024

Now we can use multi-columns descriptions thankful to markdown-it-container plugin

::::: columns
:::: column-double
first column has double relative width (ie 2/3 of total width) 
::::
:::: column-single
second column has single relative width (ie 1/3 of total width)
::::
:::::
🔍 Preview

image
image

@Koc Koc requested review from susnux and Chartman123 June 9, 2024 19:03
@susnux
Copy link
Collaborator

susnux commented Jun 12, 2024

I am not sure about this, I do not see a good use case and will make thing more complex.
I would probably stick with CommonMark to keep it simple.

Opinions @jancborchardt @Chartman123 ?

@Chartman123
Copy link
Collaborator

Yeah same for me... another dependency for only a really small benefit.

@Koc
Copy link
Collaborator Author

Koc commented Jun 12, 2024

for our use case It has sense for students quizzes, e.g. we have some image/schema on the left column and a question on the right column

@Koc Koc force-pushed the feature/add-markdown-it-container-plugin branch from a2cff14 to 535e017 Compare June 16, 2024 21:12
@Koc Koc force-pushed the feature/add-markdown-it-container-plugin branch from 535e017 to bb18466 Compare June 16, 2024 21:19
@Koc
Copy link
Collaborator Author

Koc commented Jun 16, 2024

Updates:

  • properly handle columns on mobile
  • added more real-life example in PR description
  • fixed pipeline

@Chartman123
Copy link
Collaborator

@Koc thanks for the updated description with the preview... How would this work together with your other PR to implement Text as a Markdown editor? As far as I could see Text doesn't support multi-columns.

@Koc
Copy link
Collaborator Author

Koc commented Jun 17, 2024

@Chartman123 I've plan to close #2164 because it requires much more work than I expected for adding images support. So there are no any conflicts with this 2 PRs anymore 😃

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Text doesn’t support multi-columns, I am also hesitant to add this. As mentioned, we shouldn’t stray too much from a standard, and at least be internally consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants