-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve styles of layout for QuestionFile #2253 #2259
Conversation
I guess for a long term it would be nice to add |
a1b8f64
to
ca2520e
Compare
Just use the variables, but otherwise fine :) |
@susnux for some reason it not works for me with variables 😕 Input should have Seems like it's overwritten with |
ca2520e
to
b74f61e
Compare
No starting with Nextcloud 30 all inputs should be 34px, that why we should only use the variables to be independent from the server version. |
ok, but how can I properly calculate paddings? |
Paddings should always be multiple of |
Signed-off-by: Konstantin Myakshin <[email protected]>
b74f61e
to
a7889ec
Compare
I pushed another commit with unifies the style with other inputs form Nextcloud. Note that it might look not 100% equal currently (border width), but this is due to a missing fix for e.g. NcDatetimePicker which will be release this week. Feel free to adjust or even drop my commit if you want to adjust :) |
Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Konstantin Myakshin <[email protected]>
a7889ec
to
5ca10d1
Compare
@susnux mate, it looks really amazing, thank you. This css is too hard for backend developers like me 🙈 . I've fixed formatting to pass pipeline |
we have ticket for that™ nextcloud-libraries/nextcloud-vue#4339 |
@Koc yeah nice, so we could switch in the future, when it's integrated into the lib Until then: let's get this merged :) |
See #2253 for more info. I'm not css-guy, so, if you have any suggestions how to fix it in a proper way - welcome 🙏
Fixed version has same height and paddings line other input types for both edit/view versions: