Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow guests to open public pages again #2294

Closed
wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 21, 2024

Steps

  1. Create a public form
  2. Open it as a guest
  3. 💥
Cannot assign null to property OCA\Forms\Service\ConfigService::$currentUser of type OCP\IUser

// After fixing that
Cannot assign null to property OCA\Forms\Activity\ActivityManager::$currentUser of type OCP\IUser

Not sure if you want to apply some hardening to prevent methods from calling things on currentUser which can be null now, so please take over @susnux

@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews labels Aug 21, 2024
@Chartman123 Chartman123 linked an issue Aug 21, 2024 that may be closed by this pull request
@nickvergessen
Copy link
Member Author

Fixed via #2293

@Chartman123 Chartman123 deleted the bugfix/noid/fix-guest-support branch September 1, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sharing broken in 4.3.0-alpha4
2 participants