Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update values in QuestionMultiple component correctly when isUnique === true #2323

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Chartman123
Copy link
Collaborator

This fixes #2307 where updating values in the QuestionMultiple component was not working correctly. The onChange method has been updated to handle unique values correctly by using the flat method. Additionally, a typo in a comment has been fixed.

@Chartman123 Chartman123 added bug Something isn't working javascript Javascript related ticket 3. to review Waiting for reviews labels Sep 15, 2024
@Chartman123 Chartman123 added this to the 4.3 milestone Sep 15, 2024
@Chartman123 Chartman123 changed the title Fix issue with updating values in QuestionMultiple component fix: update values in QuestionMultiple component correctly when isUnique === true Sep 15, 2024
@Chartman123 Chartman123 self-assigned this Sep 15, 2024
@Koc
Copy link
Collaborator

Koc commented Sep 16, 2024

tested on local env, works fine ✔️
image

@Chartman123 Chartman123 merged commit b6d7eaf into main Sep 16, 2024
42 checks passed
@Chartman123 Chartman123 deleted the fix/2307 branch September 16, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Other" option doesn't work with radio buttons
2 participants