chore: fix usage of deprecated functions and adjust code style #47553
+82
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
requested review from
Fenn-CS,
Pytal,
a team and
skjnldsv
and removed request for
a team
skjnldsv
approved these changes
Sep 3, 2024
susnux
force-pushed
the
chore/cleanup-warnings
branch
from
7ea7d84
to
794dedd
Compare
skjnldsv
reviewed
Sep 19, 2024
| @@ -10,6 +10,8 @@ import { | |||
| showWarning, | |||
| } from '@nextcloud/dialogs' | |||
|
|
|||
| /** @typedef {import('toastify-js')} Toast */ | |||
|
|
|||
| export default { | |||
| /** | |||
| * @deprecated 19.0.0 use `showSuccess` from the `@nextcloud/dialogs` package instead | |||
There was a problem hiding this comment.
Lets' drop OCP.toast, it's been far over 3 years
skjnldsv
approved these changes
Sep 19, 2024
provokateurin
approved these changes
Sep 19, 2024
susnux
force-pushed
the
chore/cleanup-warnings
branch
from
794dedd
to
b84f667
Compare
|
/compile |
This solves 57 ESLint warnings by replacing deprecated code with `@nextcloud/` libraries, as well as adding missing type information, importing jQuery instead of relying on global one, and the same with Moment.js. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
susnux
force-pushed
the
chore/cleanup-warnings
branch
from
ba6a43b
to
b6facb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This solves 57 ESLint warnings by replacing deprecated code with
@nextcloud/libraries, as well as adding missing type information, importing jQuery instead of relying on global one, and the same with Moment.js.Checklist