Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add proper deprecation dates where missing #48196

Merged
merged 2 commits into from
Sep 20, 2024
Merged

chore: Add proper deprecation dates where missing #48196

merged 2 commits into from
Sep 20, 2024
+50 −59

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 18, 2024 •
edited
Loading

Summary

Looked up deprecation date where missing.

Checklist

@susnux susnux added 3. to review Waiting for reviews technical debt labels Sep 18, 2024
@susnux susnux added this to the Nextcloud 31 milestone Sep 18, 2024
provokateurin
provokateurin approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also extend the regex to enforce this?
And please also backport what is possible.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 19, 2024
View reviewed changes
apps/files_sharing/lib/ShareBackend/File.php
* @return string
*/
public function generateTarget($itemSource, $shareWith, $exclude = null) {
public function generateTarget($itemSource, $shareWith) {

Check notice

Code scanning / Psalm

MoreSpecificImplementedParamType Note

Argument 2 of OCA\Files_Sharing\ShareBackend\File::generateTarget has the more specific type 'string', expecting 'false|string' as defined by OCP\Share_Backend::generateTarget
@susnux susnux merged commit 4ba3d4a into master Sep 20, 2024
174 checks passed
@susnux susnux deleted the chore/add-deprecation-date branch September 20, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc come-nc approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @juliushaertl @provokateurin @come-nc