chore: Remove legacy UI scripts and styles from files #48241
Merged
+13
−20,491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to Vue Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…emove it Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
3. to review
susnux
requested review from
Fenn-CS,
szaimen and
sorbaugh
and removed request for
a team
Fenn-CS
approved these changes
Sep 20, 2024
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
skjnldsv
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we have the Vue UI everywhere lets remove all legacy scripts and styles.
For the styles there might be regressions, but I could not spot any yet, so lets go with it as early as possible!
Also for the scripts there is only one "valid" use case: Legacy sidebar tabs that were deprecated 5 (!) years ago, so nothing to worry about I would expect.
Checklist