fix: remove long-unused desktop option #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
reviewed
Jan 13, 2023
|
@solracsf could you squash the commits? What do you think about the repair step? |
AndyScherzinger
force-pushed
the
remove-desktop
branch
from
1364bfc
to
a887c93
Compare
- Remove desktop option - Remove handling code - Remove tests - Add repair step to remove possible config DB entry Signed-off-by: Git'Fellow <[email protected]> Signed-off-by: Arthur Schiwon <[email protected]>
|
squashed, rebased, adjusted and added the repair step |
|
Sorry, I've totally forgot this one 😿 |
- getAppValue() returns strings Signed-off-by: Arthur Schiwon <[email protected]>
No worries – thanks again for the pre-work :) |
blizzz
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #675
Signed-off-by: Git'Fellow [email protected]