Fix: keep local groups when there is no group mapping set up #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
force-pushed
the
fix/805/keep-local-groups
branch
from
56b13ad
to
137f8c9
Compare
blizzz
force-pushed
the
fix/805/keep-local-groups
branch
from
137f8c9
to
9fffc5f
Compare
|
Need to improve the test further, the logic stands. |
juliushaertl
approved these changes
Jan 30, 2024
- when no group mapping is aet up in the relevant SAML configuration, a migration shall not happen. - This is the test case for this scenario Signed-off-by: Arthur Schiwon <[email protected]>
- the backend would aggressively Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/805/keep-local-groups
branch
from
61b66b9
to
579bf97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #805