Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(db): Avoid double querying #834

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

ChristophWurst
Copy link
Member

  1. If you check for existence, then fetch a prop -> fetch the prop directly
  2. If you check for existence, then delete -> delete directly

I have not tested these changes.

@blizzz
Copy link
Member

blizzz commented Apr 29, 2024

Did not test yet, would like to throw working integration tests at it, needs #837

Signed-off-by: Christoph Wurst <[email protected]>
@blizzz blizzz force-pushed the perf/db/avoid-double-query branch from 32bee99 to 5b28e7a Compare April 30, 2024 07:55
@blizzz
Copy link
Member

blizzz commented Apr 30, 2024

now tested

@blizzz blizzz merged commit 4630fee into master Apr 30, 2024
40 checks passed
@blizzz blizzz deleted the perf/db/avoid-double-query branch April 30, 2024 18:41
@blizzz
Copy link
Member

blizzz commented Apr 30, 2024

@ChristophWurst do you fance a backport to cover NC 27 (and actually down to 25)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants