Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented PostLoginEvent in SAMLController #870

Closed
wants to merge 2 commits into from

Conversation

x7airworker
Copy link

This will also fix #426.

@blizzz
Copy link
Member

blizzz commented Aug 2, 2024

Tests need adjustments.

Also I just got aware about #851 with different event classes 😕

@x7airworker
Copy link
Author

Because I am using a custom user backend, I have no need for the events mentioned in #851 although I agree that they should be implemented. I'll be happy to adjust the test cases if you can point me in the right direction. I am not familiar with writing tests for Nextcloud Apps and especially testing event dispatching, but I'll try my best.

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@x7airworker
Copy link
Author

@blizzz Could you take a look at my added test assertions?

@blizzz
Copy link
Member

blizzz commented Aug 28, 2024

@x7airworker sure, I try to do it this week. Btw, pushing commits do not trigger Github notifications, a comment like yours now is helping catching attention :)

@blizzz
Copy link
Member

blizzz commented Sep 9, 2024

Tests need adjustments.

Also I just got aware about #851 with different event classes 😕

@x7airworker sorry for bringing this up late. I was checking with the server team, and indeed we have here a duplicated event for whatever reason. The goal is now set to sunset PostLoginEvent in favor of UserLoggedInEvent, which is also consistent with the modern naming of events. Again apologies for the forth-and-back.

Thus is is better to continue with #851 (i have to have a closer look at it still), but the tests would be relevant there just as well.

@x7airworker x7airworker closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserLoggedInEvent nor PostLoginEvent is emitted for user logins
2 participants