-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented PostLoginEvent in SAMLController #870
Conversation
Tests need adjustments. Also I just got aware about #851 with different event classes 😕 |
Because I am using a custom user backend, I have no need for the events mentioned in #851 although I agree that they should be implemented. I'll be happy to adjust the test cases if you can point me in the right direction. I am not familiar with writing tests for Nextcloud Apps and especially testing event dispatching, but I'll try my best. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
@blizzz Could you take a look at my added test assertions? |
@x7airworker sure, I try to do it this week. Btw, pushing commits do not trigger Github notifications, a comment like yours now is helping catching attention :) |
@x7airworker sorry for bringing this up late. I was checking with the server team, and indeed we have here a duplicated event for whatever reason. The goal is now set to sunset Thus is is better to continue with #851 (i have to have a closer look at it still), but the tests would be relevant there just as well. |
This will also fix #426.