Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Test failures #3587

Merged
merged 9 commits into from
Jul 5, 2023
Merged

FIX: Test failures #3587

merged 9 commits into from
Jul 5, 2023

Conversation

effigies
Copy link
Member

@effigies effigies commented Jul 5, 2023

Trying to resolve the obvious issues in current test failures

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +15.00 🎉

Comparison is base (4829683) 48.27% compared to head (5e2fd1c) 63.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3587       +/-   ##
===========================================
+ Coverage   48.27%   63.28%   +15.00%     
===========================================
  Files         309      308        -1     
  Lines       40908    40876       -32     
  Branches     5383     5485      +102     
===========================================
+ Hits        19748    25868     +6120     
+ Misses      21053    13997     -7056     
- Partials      107     1011      +904     
Impacted Files Coverage Δ
nipype/info.py 84.37% <ø> (ø)
nipype/interfaces/dcm2nii.py 50.00% <ø> (+11.57%) ⬆️
nipype/testing/__init__.py 87.50% <ø> (+37.50%) ⬆️

... and 118 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member Author

effigies commented Jul 5, 2023

This fixes 3.8+. Will drop 3.7 in a separate PR.

@effigies effigies merged commit 7d4808f into nipy:master Jul 5, 2023
15 of 16 checks passed
@effigies effigies deleted the fix/test-failures branch July 5, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant