Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Apply ruff/Pyflakes rules (F) #3681

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

Summary

Apply Pyflakes (F) rules, except:

  • F401 (831 errors!)
  • F403
  • F811 (left for later)
  • F821 (fixed some occurrences and left a few for later)
  • F841 (fixed some occurrences and left a few for later)

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 26.82927% with 30 lines in your changes missing coverage. Please review.

Project coverage is 39.46%. Comparing base (4d1352a) to head (70f42d4).

Files with missing lines Patch % Lines
nipype/interfaces/cmtk/parcellation.py 0.00% 8 Missing ⚠️
nipype/interfaces/minc/minc.py 0.00% 3 Missing ⚠️
nipype/interfaces/ants/resampling.py 0.00% 2 Missing ⚠️
nipype/interfaces/io.py 0.00% 2 Missing ⚠️
nipype/interfaces/mrtrix3/connectivity.py 0.00% 2 Missing ⚠️
nipype/__init__.py 0.00% 1 Missing ⚠️
nipype/algorithms/misc.py 0.00% 1 Missing ⚠️
nipype/interfaces/cmtk/tests/test_nbs.py 50.00% 1 Missing ⚠️
nipype/interfaces/dipy/simulate.py 0.00% 1 Missing ⚠️
nipype/interfaces/tests/test_io.py 0.00% 1 Missing ⚠️
... and 8 more

❗ There is a different number of reports uploaded between BASE (4d1352a) and HEAD (70f42d4). Click for more details.

HEAD has 62 uploads less than BASE
Flag BASE (4d1352a) HEAD (70f42d4)
69 7
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3681       +/-   ##
===========================================
- Coverage   70.83%   39.46%   -31.37%     
===========================================
  Files        1276     1276               
  Lines       59314    59203      -111     
  Branches     9824     9824               
===========================================
- Hits        42013    23365    -18648     
- Misses      16125    35671    +19546     
+ Partials     1176      167     -1009     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

F401 imported but unused
F523 `.format` call has unused arguments
F541 f-string without any placeholders
F821 Undefined name

I have left some occurrences, to be fixed in a later pull request.
F841 Local variable is assigned to but never used

I have left a few occurrences, to be examined later.
F901 `raise NotImplemented` should be `raise NotImplementedError`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant