lib/helpers: refactor mkPlugin helpers

[GaetanLepage]

No description provided.

[MattSturgeon]

Apologies for the number of comments, you've probably already considered most of them.

Let's discuss tomorrow!

[MattSturgeon]

I would be tempted to restructure the scopes a little:

  plugins = {
    mkPlugin = import ./mk-plugin.nix { inherit lib nixvimOptions nixvimUtils; };
    inherit (neovim-plugin) mkNeovimPlugin;
    inherit (vim-plugin) mkVimPlugin;
  };

  # Deprecated scope, use plugins.mkNeovimPlugin going forward
  neovim-plugin = import ./neovim-plugin.nix {
    inherit
      lib
      nixvimOptions
      nixvimUtils
      toLuaObject
      mkPlugin
      ;
  };

  # Deprecated scope, use plugins.mkVimPlugin going forward
  vim-plugin = import ./vim-plugin.nix {
    inherit
      lib
      nixvimOptions
      nixvimUtils
      mkPlugin
      ;
  };

[MattSturgeon]

This is slowly improving:

$ rg 'extraOptionsOptions' --files-with-matches | wc -l
68

[GaetanLepage]

Yup. Once the rest of the internal refactors will be over (soon as hope), we can focus on modernizing the rest of the codebase.

[MattSturgeon]

Since you declare default args, you can just do // extraOptions, unless this attrs is recursive.

Suggested change

	extraOptions = settingsOption // (args.extraOptions or { });
	extraOptions = settingsOption // extraOptions;

[GaetanLepage]

Indeed !

[MattSturgeon]

Should this handle opt.termguicolors too?

[MattSturgeon]

Suggested change

	inherit description url;
	path = [
	namespace
	name
	];
	inherit description url path;

Let's define this in a wider scope or as a default-arg so we can use it here and in the deprecations.

[MattSturgeon]

Suggested change

	options.${namespace}.${name} =
	options = setAttrByPath path (

[GaetanLepage]

You find this clearer ?

[MattSturgeon]

I think it's more flexible, if we ever support having a nested namespace/path

[MattSturgeon]

Suggested change

	cfg = config.${namespace}.${name};
	cfg = getAttrFromPath path config;