Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. #4230

Closed
wants to merge 1 commit into from

Conversation

xcyang11
Copy link

@xcyang11 xcyang11 commented Dec 4, 2023

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for this kind of bug). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@xcyang11 xcyang11 changed the title fixing the compilation issue with 3 test suites. Hopefully it helps. fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites . Hopefully it helps. It was a school project that ask me to do some contributions, sorry if it didn't help Dec 4, 2023
@xcyang11 xcyang11 changed the title fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites . Hopefully it helps. It was a school project that ask me to do some contributions, sorry if it didn't help fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. It was a school project that ask me to do some contributions, sorry if it didn't help Dec 4, 2023
@xcyang11 xcyang11 changed the title fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. It was a school project that ask me to do some contributions, sorry if it didn't help fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. It was a school project that ask me to do some contributions. It may be complete useless. Sorry for the trouble I caused. Dec 4, 2023
@xcyang11 xcyang11 changed the title fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. It was a school project that ask me to do some contributions. It may be complete useless. Sorry for the trouble I caused. fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. It was a school project that asks me to do some contributions. It may be completely useless. Sorry for the trouble I caused. Dec 4, 2023
@xcyang11 xcyang11 changed the title fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. It was a school project that asks me to do some contributions. It may be completely useless. Sorry for the trouble I caused. fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. It was a school project that asked me to do some contributions. It may be completely useless. Sorry for the trouble I caused. Dec 4, 2023
@xcyang11 xcyang11 changed the title fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. It was a school project that asked me to do some contributions. It may be completely useless. Sorry for the trouble I caused. fixing the compilation issue with use of overloaded operator '<=>' is ambiguous #4197 and 3 test suites. Dec 4, 2023
@xcyang11
Copy link
Author

xcyang11 commented Dec 4, 2023

Meant to address "use of overloaded operator '<=>' is ambiguous #4197" #4197, which I found on Ovio website. This is a school project that asks me to make contributions to an open-source project. My work may be completely useless. Sorry for the troubles.
You may shut down the pull request by your convenience.

@xcyang11 xcyang11 closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant