build: describe the fix for compiling android node.js on an x86_64 host #54995
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for future reference, there's no need to keep making new PRs, you can reuse the old ones |
RedYetiDev
reviewed
Sep 18, 2024
android_configure.py
Outdated
Comment on lines
65
to
66
| os.environ['CC_host'] = os.popen("which gcc").read().strip() | ||
| os.environ['CCX_host'] = os.popen("which g++").read().strip() |
There was a problem hiding this comment.
Does the Builtin shutil have something for this?
There was a problem hiding this comment.
This is a better way, and I will submit it for modification.
RedYetiDev
added
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RedYetiDev #54908 Modify the description