Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 13.0 #55014

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 0 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -909,9 +909,6 @@ else
ifeq ($(findstring ppc64,$(UNAME_M)),ppc64)
DESTCPU ?= ppc64
else
ifeq ($(findstring ppc,$(UNAME_M)),ppc)
DESTCPU ?= ppc
else
ifeq ($(findstring s390x,$(UNAME_M)),s390x)
DESTCPU ?= s390x
else
Expand Down Expand Up @@ -948,7 +945,6 @@ endif
endif
endif
endif
endif
ifeq ($(DESTCPU),x64)
ARCH=x64
else
Expand All @@ -961,9 +957,6 @@ else
ifeq ($(DESTCPU),ppc64)
ARCH=ppc64
else
ifeq ($(DESTCPU),ppc)
ARCH=ppc
else
ifeq ($(DESTCPU),s390)
ARCH=s390
else
Expand All @@ -981,7 +974,6 @@ endif
endif
endif
endif
endif

# node and v8 use different arch names (e.g. node 'x86' vs v8 'ia32').
# pass the proper v8 arch name to $V8_ARCH based on user-specified $DESTCPU.
Expand Down
12 changes: 2 additions & 10 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.9',
'v8_embedder_string': '-node.7',

##### V8 defaults for Node.js #####

Expand Down Expand Up @@ -110,7 +110,7 @@
'v8_base': '<(PRODUCT_DIR)/libv8_snapshot.a',
}],
# V8 pointer compression only supports 64bit architectures.
['target_arch in "arm ia32 mips mipsel ppc"', {
['target_arch in "arm ia32 mips mipsel"', {
'v8_enable_pointer_compression': 0,
'v8_enable_31bit_smis_on_64bit_arch': 0,
'v8_enable_sandbox': 0
Expand Down Expand Up @@ -516,10 +516,6 @@
'cflags': [ '-m64' ],
'ldflags': [ '-m64' ],
}],
[ 'host_arch=="ppc" and OS not in "aix os400"', {
'cflags': [ '-m32' ],
'ldflags': [ '-m32' ],
}],
[ 'host_arch=="ppc64" and OS not in "aix os400"', {
'cflags': [ '-m64', '-mminimal-toc' ],
'ldflags': [ '-m64' ],
Expand All @@ -540,10 +536,6 @@
'cflags': [ '-m64' ],
'ldflags': [ '-m64' ],
}],
[ 'target_arch=="ppc" and OS not in "aix os400"', {
'cflags': [ '-m32' ],
'ldflags': [ '-m32' ],
}],
[ 'target_arch=="ppc64" and OS not in "aix os400"', {
'cflags': [ '-m64', '-mminimal-toc' ],
'ldflags': [ '-m64' ],
Expand Down
2 changes: 1 addition & 1 deletion configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@

valid_os = ('win', 'mac', 'solaris', 'freebsd', 'openbsd', 'linux',
'android', 'aix', 'cloudabi', 'os400', 'ios')
valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'mips64el', 'ppc',
valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'mips64el',
'ppc64', 'x64', 'x86', 'x86_64', 's390x', 'riscv64', 'loong64')
valid_arm_float_abi = ('soft', 'softfp', 'hard')
valid_arm_fpu = ('vfp', 'vfpv3', 'vfpv3-d16', 'neon')
Expand Down
12 changes: 7 additions & 5 deletions deps/v8/.clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
---
Checks: '-*,
bugprone-unique-ptr-array-mismatch,
# google-build-explicit-make-pair,
google-default-arguments,
google-explicit-constructor,
google-readability-casting,
modernize-redundant-void-arg,
modernize-replace-random-shuffle,
modernize-shrink-to-fit,
Expand All @@ -11,12 +15,10 @@
# modernize-use-equals-delete,
modernize-use-nullptr,
modernize-use-override,
# google-build-explicit-make-pair,
google-default-arguments,
google-explicit-constructor,
google-readability-casting'
performance-inefficient-vector-operation,
performance-trivially-destructible,
performance-unnecessary-copy-initialization'
WarningsAsErrors: ''
HeaderFilterRegex: ''
AnalyzeTemporaryDtors: false
...

3 changes: 3 additions & 0 deletions deps/v8/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@
/third_party/colorama/src
!/third_party/cpu_features
/third_party/cpu_features/src
!/third_party/fast_float
/third_party/fast_float/src/*
!/third_party/fast_float/src/include
!/third_party/glibc
!/third_party/googletest
/third_party/googletest/src/*
Expand Down
3 changes: 3 additions & 0 deletions deps/v8/AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ Anton Bershanskiy <[email protected]>
Anton Bikineev <[email protected]>
Ao Wang <[email protected]>
Archil Sharashenidze <[email protected]>
Artem Kobzar <[email protected]>
Arthur Islamov <[email protected]>
Asuka Shikina <[email protected]>
Aurèle Barrière <[email protected]>
Bala Avulapati <[email protected]>
Bangfu Tao <[email protected]>
Expand Down Expand Up @@ -309,6 +311,7 @@ Youfeng Hao <[email protected]>
Yu Yin <[email protected]>
Yujie Wang <[email protected]>
Yuri Iozzelli <[email protected]>
Yuri Gaevsky <[email protected]>
Yusif Khudhur <[email protected]>
Yuxiang Cao <[email protected]>
Zac Hansen <[email protected]>
Expand Down
46 changes: 39 additions & 7 deletions deps/v8/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ load(":bazel/v8-non-pointer-compression.bzl", "v8_binary_non_pointer_compression
# v8_enable_gdbjit
# v8_check_header_includes
# v8_enable_lazy_source_positions
# v8_enable_third_party_heap
# v8_third_party_heap_files
# v8_disable_write_barriers
# v8_enable_unconditional_write_barriers
# v8_enable_single_generation
Expand Down Expand Up @@ -492,8 +490,7 @@ v8_config(
],
"@v8//bazel/config:v8_target_ppc64le": [
# NOTE: Bazel rules for ppc64le weren't tested on a real system.
"V8_TARGET_ARCH_PPC64",
"V8_TARGET_ARCH_PPC_LE",
"V8_TARGET_ARCH_PPC64"
],
},
no_match_error = "Please specify a target cpu supported by v8",
Expand Down Expand Up @@ -1793,8 +1790,6 @@ filegroup(
"src/heap/stress-scavenge-observer.h",
"src/heap/sweeper.cc",
"src/heap/sweeper.h",
"src/heap/third-party/heap-api.h",
"src/heap/third-party/heap-api-stub.cc",
"src/heap/traced-handles-marking-visitor.cc",
"src/heap/traced-handles-marking-visitor.h",
"src/heap/weak-object-worklists.cc",
Expand Down Expand Up @@ -2336,6 +2331,7 @@ filegroup(
"src/runtime/runtime-test.cc",
"src/runtime/runtime-trace.cc",
"src/runtime/runtime-typedarray.cc",
"src/runtime/runtime-utils.cc",
"src/runtime/runtime-utils.h",
"src/runtime/runtime-weak-refs.cc",
"src/sandbox/bounded-size.h",
Expand Down Expand Up @@ -2557,6 +2553,8 @@ filegroup(
"src/codegen/x64/assembler-x64.cc",
"src/codegen/x64/assembler-x64.h",
"src/codegen/x64/assembler-x64-inl.h",
"src/codegen/x64/builtin-jump-table-info-x64.cc",
"src/codegen/x64/builtin-jump-table-info-x64.h",
"src/codegen/x64/constants-x64.h",
"src/codegen/x64/cpu-x64.cc",
"src/codegen/x64/fma-instr.h",
Expand Down Expand Up @@ -2889,7 +2887,6 @@ filegroup(
"src/wasm/leb-helper.h",
"src/wasm/local-decl-encoder.cc",
"src/wasm/local-decl-encoder.h",
"src/wasm/memory-tracing.cc",
"src/wasm/memory-tracing.h",
"src/wasm/module-compiler.cc",
"src/wasm/module-compiler.h",
Expand Down Expand Up @@ -2924,6 +2921,9 @@ filegroup(
"src/wasm/wasm-builtin-list.h",
"src/wasm/wasm-code-manager.cc",
"src/wasm/wasm-code-manager.h",
"src/wasm/wasm-code-pointer-table.cc",
"src/wasm/wasm-code-pointer-table.h",
"src/wasm/wasm-code-pointer-table-inl.h",
"src/wasm/wasm-debug.cc",
"src/wasm/wasm-debug.h",
"src/wasm/wasm-deopt-data.cc",
Expand Down Expand Up @@ -3282,6 +3282,8 @@ filegroup(
"src/compiler/turboshaft/build-graph-phase.cc",
"src/compiler/turboshaft/build-graph-phase.h",
"src/compiler/turboshaft/builtin-call-descriptors.h",
"src/compiler/turboshaft/builtin-compiler.cc",
"src/compiler/turboshaft/builtin-compiler.h",
"src/compiler/turboshaft/csa-optimize-phase.cc",
"src/compiler/turboshaft/csa-optimize-phase.h",
"src/compiler/turboshaft/dataview-lowering-reducer.h",
Expand All @@ -3303,6 +3305,7 @@ filegroup(
"src/compiler/turboshaft/explicit-truncation-reducer.h",
"src/compiler/turboshaft/fast-api-call-lowering-reducer.h",
"src/compiler/turboshaft/fast-hash.h",
"src/compiler/turboshaft/field-macro.inc",
"src/compiler/turboshaft/graph.cc",
"src/compiler/turboshaft/graph.h",
"src/compiler/turboshaft/graph-builder.cc",
Expand Down Expand Up @@ -3484,6 +3487,9 @@ filegroup(
"src/compiler/turboshaft/wasm-gc-typed-optimization-reducer.cc",
"src/compiler/turboshaft/wasm-gc-typed-optimization-reducer.h",
"src/compiler/turboshaft/wasm-load-elimination-reducer.h",
"src/compiler/turboshaft/wasm-in-js-inlining-phase.cc",
"src/compiler/turboshaft/wasm-in-js-inlining-phase.h",
"src/compiler/turboshaft/wasm-in-js-inlining-reducer-inl.h",
"src/compiler/turboshaft/wasm-lowering-phase.cc",
"src/compiler/turboshaft/wasm-lowering-phase.h",
"src/compiler/turboshaft/wasm-lowering-reducer.h",
Expand Down Expand Up @@ -3588,6 +3594,7 @@ filegroup(
"src/builtins/builtins-lazy-gen.h",
"src/builtins/builtins-microtask-queue-gen.cc",
"src/builtins/builtins-number-gen.cc",
"src/builtins/builtins-number-tsa.cc",
"src/builtins/builtins-object-gen.cc",
"src/builtins/builtins-object-gen.h",
"src/builtins/builtins-promise-gen.cc",
Expand All @@ -3607,6 +3614,7 @@ filegroup(
"src/builtins/builtins-utils-gen.h",
"src/builtins/growable-fixed-array-gen.cc",
"src/builtins/growable-fixed-array-gen.h",
"src/builtins/number-builtins-reducer-inl.h",
"src/builtins/profile-data-reader.cc",
"src/builtins/profile-data-reader.h",
"src/builtins/setup-builtins-internal.cc",
Expand All @@ -3616,6 +3624,8 @@ filegroup(
"third_party/v8/codegen/fp16-inl.h",
"src/codegen/code-stub-assembler-inl.h",
"src/codegen/code-stub-assembler.h",
"src/codegen/define-code-stub-assembler-macros.inc",
"src/codegen/undef-code-stub-assembler-macros.inc",
"src/heap/setup-heap-internal.cc",
"src/ic/accessor-assembler.cc",
"src/ic/accessor-assembler.h",
Expand All @@ -3629,6 +3639,8 @@ filegroup(
"src/interpreter/interpreter-assembler.h",
"src/interpreter/interpreter-generator.cc",
"src/interpreter/interpreter-generator.h",
"src/interpreter/interpreter-generator-tsa.cc",
"src/interpreter/interpreter-generator-tsa.h",
"src/interpreter/interpreter-intrinsics-generator.cc",
"src/interpreter/interpreter-intrinsics-generator.h",
"src/numbers/integer-literal.h",
Expand Down Expand Up @@ -3796,6 +3808,25 @@ filegroup(
}),
)

v8_library(
name = "lib_fast_float",
srcs = [
"third_party/fast_float/src/include/fast_float/ascii_number.h",
"third_party/fast_float/src/include/fast_float/bigint.h",
"third_party/fast_float/src/include/fast_float/constexpr_feature_detect.h",
"third_party/fast_float/src/include/fast_float/decimal_to_binary.h",
"third_party/fast_float/src/include/fast_float/digit_comparison.h",
"third_party/fast_float/src/include/fast_float/fast_float.h",
"third_party/fast_float/src/include/fast_float/fast_table.h",
"third_party/fast_float/src/include/fast_float/float_common.h",
"third_party/fast_float/src/include/fast_float/parse_number.h",
],
hdrs = [ "third_party/fast_float/src/include/fast_float/fast_float.h" ],
includes = [
"third_party/fast_float/src/include",
],
)

v8_library(
name = "lib_fp16",
srcs = ["third_party/fp16/src/include/fp16.h"],
Expand Down Expand Up @@ -4299,6 +4330,7 @@ v8_library(
":noicu/generated_torque_definitions",
],
deps = [
":lib_fast_float",
":lib_fp16",
":v8_libbase",
"//external:absl_btree",
Expand Down
Loading
Loading