chore: noop per file (#3544)

nodejs · Sep 4, 2024 · 4b8958a · 4b8958a
1 parent 408aa70
commit 4b8958a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/lib/api/api-pipeline.js b/lib/api/api-pipeline.js
@@ -15,6 +15,8 @@ const {
 const util = require('../core/util')
 const { addSignal, removeSignal } = require('./abort-signal')
 
+function noop () {}
+
 const kResume = Symbol('resume')
 
 class PipelineRequest extends Readable {
@@ -92,7 +94,7 @@ class PipelineHandler extends AsyncResource {
     this.context = null
     this.onInfo = onInfo || null
 
-    this.req = new PipelineRequest().on('error', util.nop)
+    this.req = new PipelineRequest().on('error', noop)
 
     this.ret = new Duplex({
       readableObjectMode: opts.objectMode,
@@ -183,7 +185,7 @@ class PipelineHandler extends AsyncResource {
         context
       })
     } catch (err) {
-      this.res.on('error', util.nop)
+      this.res.on('error', noop)
       throw err
     }
 

diff --git a/lib/api/api-request.js b/lib/api/api-request.js
@@ -6,6 +6,8 @@ const { Readable } = require('./readable')
 const { InvalidArgumentError, RequestAbortedError } = require('../core/errors')
 const util = require('../core/util')
 
+function noop () {}
+
 class RequestHandler extends AsyncResource {
   constructor (opts, callback) {
     if (!opts || typeof opts !== 'object') {
@@ -38,7 +40,7 @@ class RequestHandler extends AsyncResource {
       super('UNDICI_REQUEST')
     } catch (err) {
       if (util.isStream(body)) {
-        util.destroy(body.on('error', util.nop), err)
+        util.destroy(body.on('error', noop), err)
       }
       throw err
     }
@@ -159,7 +161,7 @@ class RequestHandler extends AsyncResource {
       this.body = null
 
       if (util.isStream(body)) {
-        body.on('error', util.nop)
+        body.on('error', noop)
         util.destroy(body, err)
       }
     }

diff --git a/lib/api/api-stream.js b/lib/api/api-stream.js
@@ -7,6 +7,8 @@ const { InvalidArgumentError, InvalidReturnValueError } = require('../core/error
 const util = require('../core/util')
 const { addSignal, removeSignal } = require('./abort-signal')
 
+function noop () {}
+
 class StreamHandler extends AsyncResource {
   constructor (opts, factory, callback) {
     if (!opts || typeof opts !== 'object') {
@@ -39,7 +41,7 @@ class StreamHandler extends AsyncResource {
       super('UNDICI_STREAM')
     } catch (err) {
       if (util.isStream(body)) {
-        util.destroy(body.on('error', util.nop), err)
+        util.destroy(body.on('error', noop), err)
       }
       throw err
     }

diff --git a/lib/core/util.js b/lib/core/util.js
@@ -67,8 +67,6 @@ function wrapRequestBody (body) {
   }
 }
 
-function nop () {}
-
 function isStream (obj) {
   return obj && typeof obj === 'object' && typeof obj.pipe === 'function' && typeof obj.on === 'function'
 }
@@ -664,7 +662,6 @@ Object.setPrototypeOf(normalizedMethodRecords, null)
 
 module.exports = {
   kEnumerableProperty,
-  nop,
   isDisturbed,
   toUSVString,
   isUSVString,