ci: improve readability and correctness #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work with any recent version of Visual Studio. It didn't work before because I was missing "-arch=x64" and got a 32-bit compiler that likely couldn't address enough memory. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
These didn't seem to hurt, but they weren't helping either. This path must be correct if multiple versions of Qt are installed. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
cebtenzzre
added a commit
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Jared Van Bortel <[email protected]>
manyoso
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's getting hard to keep track of all of the incidental CI changes I'd like to make, which mostly seem to be in PRs that are blocked on something, so I am putting them here. Changes made:
-arch=x64, which is needed to get a compiler that runs as a 64-bit application (regardless of target platform).