ui: UTF-8 support in input fields #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR trades UTF8 support for one extra memory allocation per input field.
Before, all UI code was using
&mut Stringand was operating right on the user data, reallocating memory only when neccesary. After, each input field copies String into a Vec, and than copies the data back.Technically, all the UTF8 bugs are fixable without Vec, we just need to make a very clear distinguish for "cursor pointing into a character"/"cursor pointing into a byte". With a lot faster navigation/slicing of Vec than a a char's iterator from a string, perfomance/memory tradeoff is not super obvious, and with implementation being so much easier with a Vec - let's chose this route.