Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): identify from app to pass traits #6537

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(web): identify from app to pass traits #6537

merged 1 commit into from
Sep 19, 2024

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Sep 19, 2024

What changed? Why was the change needed?

This helps with passing the proper account details to destinations

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder how this fixes the issue don't we identify by Id?

@scopsy scopsy changed the title fix: identify from app to pass traits fix(web): identify from app to pass traits Sep 19, 2024
@scopsy
Copy link
Contributor Author

scopsy commented Sep 19, 2024

@djabarovgeorge It will just help with updating the contact credentials during the identify method, we also send the information when upserting users. But not all segment destinations support this. This particular one is for Hubspot

@scopsy scopsy merged commit 9eb4942 into next Sep 19, 2024
27 of 29 checks passed
@scopsy scopsy deleted the hub-spot-identify branch September 19, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants