chore: branch is available when event is workflow_dispatch #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have had to make this change as well, as we do on demand deployments. Also we have multiple branches so found if a branch was not deployed from that workflow recently it was failing to find the last successful commit from a few days prior. |
Tirke
changed the title
|
I suspect a tweak might be required for findExistingCommit as well, got a branch that has not been run for 2months but has a heap of changes merged from another branch and seems it fails to find the commit to use. |
|
FYI - this is my hardcoded solution for allowing more than 100 commits |
mandarini
approved these changes
May 22, 2024
|
Thank you for the PR @Tirke ! I think this change makes sense because it ensures that the branch is set correctly for |
mandarini
force-pushed
the
use-branch-if-workflow_dispatch
branch
from
1ad0b26
to
5f3f584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure why you don't always set the branch, especially since the branch can be overridden by the inputs to be always available, meaning the branch would always be set no matter the github event.
But I wanted to play it safe so I only added an exception for
workflow_dispatchwhich always runs against a branch and we should always consider the branch in that case because otherwise we would pick from ci runs from all branches which is really bad.