[W8.6b][W09-B3] Yap Ni #949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goweiwen
reviewed
Mar 18, 2018
| || obj instanceof Tagging // instanceof handles null | ||
| && ((Tagging) obj).getPerson().equals(this.person) | ||
| && ((Tagging) obj).getTag().equals(this.tag) | ||
| && ((Tagging) obj).getChange().equals(this.getChange()); |
There was a problem hiding this comment.
Instead of using this.getChange(), we can use this.change as well.
| public class Tagging { | ||
|
|
||
| public static final String SYMBOL_ADD = "+"; | ||
| public static final String SYMBOL_REMOVE = "-"; |
There was a problem hiding this comment.
If you are already using enums for Change, you can also use a Map<Enum, String> to convert from enums to your symbol. This way, the toString method will not need to care if enums are added or removed (e.g. new enum for renaming tags).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Tagging association class. Each Tagging object will represent an adding or deleting of a tag for a specific person that happened during that session.