[W8.6b][T09-B3]Aditya Agarwal #964
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,13 +25,15 @@ | |||
|
|
|||
| private final UniquePersonList allPersons; | |||
| private final UniqueTagList allTags; // can contain tags not attached to any person | |||
| public ArrayList<Tagging> tagging; //Arraylist of tagging records | |||
There was a problem hiding this comment.
Good, this is a correct place to put the list based on the UML.. taggingList might be a better name. Then, you can remove the comment.
| @@ -13,7 +14,11 @@ | |||
|
|
|||
| @Override | |||
| public CommandResult execute() { | |||
| return new CommandResult(MESSAGE_EXIT_ACKNOWEDGEMENT); | |||
| StringBuilder listOfTags = new StringBuilder(); | |||
| for(Tagging tagging: addressBook.tagging) { | |||
There was a problem hiding this comment.
Coding standard violation. Missing empty spaces.
| import seedu.addressbook.data.tag.Tag; | ||
|
|
||
| /** | ||
| * Represents whether a tag has been added or remved for a person in the current session |
There was a problem hiding this comment.
Good job for writing the header comment.
|
|
||
| private final Person person; | ||
| private final Tag tag; | ||
| private boolean isTagRemoved; |
There was a problem hiding this comment.
Using boolean is fine now since this LO requires only two states. What if later you need to capture more than two states?
|
@AdityaA1998 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.