[v1.5][T09-B2] CollegeZone #47

deborahlow97 · 2018-03-08T01:12:40Z

No description provided.

dalessr

@deborahlow97 @zuweitrack @fuadsahmawi @A0158738X Some comments added. Can make changes accordingly.

dalessr · 2018-03-10T21:15:45Z

docs/DeveloperGuide.adoc

@@ -782,6 +782,7 @@ See this https://github.com/se-edu/addressbook-level4/pull/599[PR] for the step-

 *Target user profile*:

+* NUS Students living in RC


Is it better to write as Residential College (RC) since other developers might not know what RC stands for?

dalessr · 2018-03-10T21:17:25Z

docs/DeveloperGuide.adoc

+
+|`* * *` |user |set a level of friendship with a specific person |maintain my friendships depending on a priority system set by myself
+
+|`* * *` |user |edit details of my contacts |stay updated with the current details of my friends


Here user should be replaced by your specified target users.

dalessr · 2018-03-10T21:18:49Z

docs/DeveloperGuide.adoc

+
+|`* * *` |user |edit details of my contacts |stay updated with the current details of my friends
+
+|`* * *` |forgetful RC student |to add persistent reminders |periodically remind myself to do something.


Second column inconsistent with the other user stories?

dalessr · 2018-03-10T21:20:25Z

docs/DeveloperGuide.adoc

+
+|`* *` |careless RC student |undo a command I entered |undo a wrong command that I entered
+
+|`* *` |careless RC student |redo a command I entered |redo when I want to undo my "undo" command


No need to repeat the features that current version of addressbook already contains.

dalessr · 2018-03-10T21:21:46Z

docs/DeveloperGuide.adoc

@@ -852,6 +909,10 @@ _{More to be added}_
 .  Should work on any <<mainstream-os,mainstream OS>> as long as it has Java `1.8.0_60` or higher installed.
 .  Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.
 .  A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.
+.  Should be able to deal with invalid command inputs.


Is this an NFR or a functional requirement?

dalessr

@deborahlow97 @fuadsahmawi @zuweitrack @A0158738X some comments added.

Please note that:

Update the developer guide to describe the new features added (in Implementation part)

dalessr · 2018-03-17T11:28:07Z

README.adoc

-** Support for _Build Automation_ using Gradle and for _Continuous Integration_ using Travis CI.
+* CollegeZone is a desktop application for *NUS Residential College 4 (RC4) students*. It has a GUI but most of the user interactions happen using a CLI (Command Line Interface).
+* It's created for a RC4 resident to manage their contacts with other RC4 residents and to manage their tasks.
+


Remember to add acknowledgement for CS2103 AB4 (SE-EDU)

dalessr · 2018-03-17T11:39:00Z

src/main/java/seedu/address/logic/parser/AddressBookParser.java

@@ -51,27 +51,51 @@ public Command parseCommand(String userInput) throws ParseException {
        case AddCommand.COMMAND_WORD:
            return new AddCommandParser().parse(arguments);

+        case AddCommand.COMMAND_ALIAS:


You can actually combine the command word and command alias together for the same command to make it clearer

dalessr · 2018-03-17T11:50:25Z

src/main/java/seedu/address/ui/PersonCard.java

    private static final String FXML = "PersonListCard.fxml";
+    private static final String[] TAG_COLOR_STYLES = new String[]{"teal", "red", "yellow", "blue", "orange", "brown",


Just a suggestion: try to use the colors which users can see the word inside the tag clearly

dalessr · 2018-03-17T11:53:04Z

src/test/java/guitests/guihandles/PersonCardHandle.java

@@ -68,4 +68,13 @@ public String getEmail() {
                .map(Label::getText)
                .collect(Collectors.toList());
    }
+
+    public List<String> getTagStyleClasses(String tag) {
+        return tagLabels


Here there should be one component after tagLabels

dalessr · 2018-03-17T11:54:15Z

src/test/java/seedu/address/logic/commands/FindCommandTest.java

+     */
+    private FindCommand prepareTagCommand(String userInput) {
+        FindCommand command =
+                new FindCommand(new TagContainsKeywordsPredicate(Arrays.asList(userInput.split("\\s+"))));


Incorrect format (not following the coding standard)

dalessr · 2018-03-18T07:33:25Z

@deborahlow97 @fuadsahmawi @zuweitrack @A0158738X
There is one thing I forgot to mention:

Think about the major and minor features you want to implement, and update your user guide to show all the new features (commands), even though you haven't started yet!

…2103-AY1718S2#47) * DeveloperGuide.adoc: add new subsection Feature Contributions * Fix capitalization of word

dalessr · 2018-03-25T06:05:15Z

@deborahlow97 @fuadsahmawi @zuweitrack @A0158738X Good job 👍

Here are something you need to take note:

Change the PR title (v1.x) before each tutorial
I have seen some coming in v2.0 labels inside user guide, remember to put in the enhancements you have done and label them as since v1.x. All the other original features can also be labeled as since v1.0 to make them consistent. Try to complete your user guide by the next tutorial
User guide can include screenshots about how to use the command and what is the expected outcome
Update FAQ and Command Summary in user guide accordingly
Inside developer guide, update the UML diagrams accordingly since you have made changes on the project structure. Include sequence diagrams for the new features inside Implementation
Add more labels inside the issue tracker (i.e. priority, status), and assign the tasks to different persons
For the issues labeled as story, the benefit part (after so that) should be put inside the description of this issue instead of title
Make sure all the PRs are linked to the corresponding issues using the issue number
Remember to close the milestone before each tutorial. I saw that the v1.2 milestone is still open
Remember to add acknowledgements for Addressbook Level 4 inside REAMDE.md. You can refer to other team' repo
Write your project portfolio

Added my picture to AboutUs

… data

Pull to local

Update use cases and NFR

Final update

…/main into V1.5Coderefactoring

Fix typos

u

Collatefinal

Update typo

u

Update Ui.png

…nto collatefinal

Shorten my portfolio

Update

Adding "functional" collated files

nus-se-pr-bot assigned sooyj Mar 8, 2018

nus-se-pr-bot added team.B2 tutorial.T09 labels Mar 8, 2018

nus-se-pr-bot assigned dalessr and unassigned sooyj Mar 8, 2018

deborahlow97 changed the title ~~[v1.0][T09-B2] Friendzone~~ [v1.0][T09-B2] CollegeZone Mar 9, 2018

dalessr reviewed Mar 10, 2018

View reviewed changes

dalessr added the reviewed-v1_0 label Mar 10, 2018

deborahlow97 changed the title ~~[v1.0][T09-B2] CollegeZone~~ [v1.1][T09-B2] CollegeZone Mar 17, 2018

dalessr reviewed Mar 17, 2018

View reviewed changes

dalessr added the reviewed-v1_1 label Mar 17, 2018

madsonic assigned sooyj Mar 18, 2018

whenzei added a commit to whenzei/main that referenced this pull request Mar 18, 2018

DeveloperGuide.adoc: add new subsection Feature Contributions (nus-cs…

666efa2

…2103-AY1718S2#47) * DeveloperGuide.adoc: add new subsection Feature Contributions * Fix capitalization of word

dalessr added the reviewed-v1_2 label Mar 25, 2018

deborahlow97 changed the title ~~[v1.1][T09-B2] CollegeZone~~ [v1.3][T09-B2] CollegeZone Mar 28, 2018

SoilChang pushed a commit to SoilChang/addressbook-level4 that referenced this pull request Apr 5, 2018

Merge pull request nus-cs2103-AY1718S2#47 from ValerianRey/master

0cc0ae7

Added my picture to AboutUs

deborahlow97 changed the title ~~[v1.3][T09-B2] CollegeZone~~ [v1.5rc][T09-B2] CollegeZone Apr 12, 2018

fuadsahmawi and others added 11 commits April 13, 2018 16:50

Clean up CalendarPanel

703cd54

Added new data util file to populate CollegeZone with sample reminder…

450bf5f

… data

Edited samplereminderdatautil.java

22536a8

Update goal and theme use cases

621c00f

Merge pull request #10 from CS2103JAN2018-T09-B2/master

c1262a2

Pull to local

Edit typo and add sortgoal use case

775fb29

Merge branch 'master' into V1.5DeveloperGuide

eb6f298

Edit RateCommand to handle invalid entries

766655f

Add username for collating

3488202

Edit RateCommand message

2f983bd

Merge pull request #229 from deborahlow97/V1.5DeveloperGuide

13dec3b

Update use cases and NFR

deborahlow97 added 24 commits April 15, 2018 21:46

Update typo

d426fbf

Merge branch 'master' into V1.5Coderefactoring

964a16d

Update typos

1913e22

Fix typo

8aedd70

Merge pull request #272 from deborahlow97/V1.5Coderefactoring

4a17c6b

Final update

Update typos

daef627

Merge branch 'V1.5Coderefactoring' of https://github.com/deborahlow97…

6e3dfff

…/main into V1.5Coderefactoring

Merge branch 'master' into V1.5Coderefactoring

1bfa06a

Merge pull request #273 from deborahlow97/V1.5Coderefactoring

861fec2

Fix typos

Merge pull request #47 from CS2103JAN2018-T09-B2/master

1cc7cd5

u

Final collate

2ac8d9b

Merge pull request #274 from deborahlow97/collatefinal

8ba713c

Collatefinal

Update typo

de6975d

Merge pull request #275 from deborahlow97/V1.5Coderefactoring

1d6deb5

Update typo

Merge pull request #48 from CS2103JAN2018-T09-B2/master

089c3d0

u

Remove file

ea1c1a1

Update Ui.png

3d0fd08

Merge branch 'master' into collatefinal

24467d5

Merge pull request #276 from deborahlow97/collatefinal

59dc583

Update Ui.png

update

d251738

Merge branch 'collatefinal' of https://github.com/deborahlow97/main i…

a0b864e

…nto collatefinal

Update

9f25394

Merge branch 'master' into collatefinal

864cfcd

Merge pull request #277 from deborahlow97/collatefinal

ffd6a7b

Shorten my portfolio

deborahlow97 changed the title ~~[v1.5rc][T09-B2] CollegeZone~~ [v1.5][T09-B2] CollegeZone Apr 15, 2018

deborahlow97 added 5 commits April 16, 2018 16:13

Update collated files

4a9f755

Merge branch 'master' of https://github.com/deborahlow97/main

c180847

Merge pull request #49 from CS2103JAN2018-T09-B2/master

6124dd0

Update

Merge branch 'master' of https://github.com/deborahlow97/main

942df1f

Merge pull request #279 from deborahlow97/master

ba882f2

Adding "functional" collated files

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v1.5][T09-B2] CollegeZone #47

[v1.5][T09-B2] CollegeZone #47

deborahlow97 commented Mar 8, 2018

dalessr left a comment

dalessr Mar 10, 2018

dalessr Mar 10, 2018

dalessr Mar 10, 2018

dalessr Mar 10, 2018

dalessr Mar 10, 2018

dalessr left a comment

dalessr Mar 17, 2018

dalessr Mar 17, 2018

dalessr Mar 17, 2018

dalessr Mar 17, 2018

dalessr Mar 17, 2018

dalessr commented Mar 18, 2018

dalessr commented Mar 25, 2018

		@@ -782,6 +782,7 @@ See this https://github.com/se-edu/addressbook-level4/pull/599[PR] for the step-

		Target user profile:

		* NUS Students living in RC


		\|`* * *` \|user \|set a level of friendship with a specific person \|maintain my friendships depending on a priority system set by myself

		\|`* * *` \|user \|edit details of my contacts \|stay updated with the current details of my friends


		\|`* * *` \|user \|edit details of my contacts \|stay updated with the current details of my friends

		\|`* * *` \|forgetful RC student \|to add persistent reminders \|periodically remind myself to do something.


		\|`* *` \|careless RC student \|undo a command I entered \|undo a wrong command that I entered

		\|`* *` \|careless RC student \|redo a command I entered \|redo when I want to undo my "undo" command

		private static final String FXML = "PersonListCard.fxml";
		private static final String[] TAG_COLOR_STYLES = new String[]{"teal", "red", "yellow", "blue", "orange", "brown",

[v1.5][T09-B2] CollegeZone #47

Are you sure you want to change the base?

[v1.5][T09-B2] CollegeZone #47

Conversation

deborahlow97 commented Mar 8, 2018

dalessr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dalessr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dalessr commented Mar 18, 2018

dalessr commented Mar 25, 2018