Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5rc][F12-B4] HuatAh! #75

Open
wants to merge 811 commits into
base: master
Choose a base branch
from

Conversation

jonleeyz
Copy link

@jonleeyz jonleeyz commented Mar 9, 2018

Auto updating Pull Request from our team repo to the course repo.

@melvintzw
@der-erlkonig
@zhangriqi

@nus-se-pr-bot
Copy link

Hi @jonleeyz, your pull request title is invalid.

For phase A, it should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2).

For phase B, it should be in the format of [v1.x][Team ID] Product Name, replacing v1.x with current milestone progress.

Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

Copy link

@OuyangDanwen OuyangDanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonleeyz @zhangriqi @der-erlkonig @melvintzw Please change the product name in readme. It should not be AB4 at this point and make the PR before the tutorial. Thanks!

Copy link

@OuyangDanwen OuyangDanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things: 1. Please update the AboutUs, ContactUs pages asap. 2. You should re-write the whole UG to reflect the changes you intent to make for your own app. (the features should be up to V2.0) Mark them accordingly with the version. 3. More details should be documented in the DG as you go along. You might not have time to do it in one shot later. You should have a product survey for DG as well. Please take note of the above points. 4. You should update the PR title each week. Replace the "X" with correct version number. Due to the incomplete UG, I have to change the team component to 0 for last tutorial as the changes are required. (the lead tutor insisted for all teams to do this) @jonleeyz @melvintzw @der-erlkonig @zhangriqi


|`*` |user with many persons in the address book |sort persons by name |locate a person easily
|`*` |user |export my current view to another format |view specific information in another format or print out a hardcopy and pass the information to subordinates

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update MSS accordingly. I believe you do have new commands which have different workflow.

@tshradheya tshradheya changed the title [v1.x][F12-B4] Loan Shark Tycoon [v1.1][F12-B4] Loan Shark Tycoon Mar 21, 2018
@jonleeyz jonleeyz changed the title [v1.1][F12-B4] Loan Shark Tycoon [v1.2][F12-B4] Loan Shark Tycoon Mar 23, 2018
Copy link

@OuyangDanwen OuyangDanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For DG, it is good that you have included some code snippets, but do not overdo it. Use of UML diagrams is lacking. Please use your UML knowledge to explain your design. It is important to have diagrams in your project portfolio. UG should be in sync with you changes. Google map feature should be also included. Same applies to other new features. You can mark "Since V1.2" to indicate them clearly, similar to the marking "Coming in V2.0". Please mark sure your UG is ready before peer testing. @jonleeyz @melvintzw @der-erlkonig @zhangriqi

wynonaK pushed a commit to wynonaK/addressbook-level4 that referenced this pull request Mar 29, 2018
…pdateStorageForAddCommand

Storage Enhancements for PetPatients
@jonleeyz jonleeyz changed the title [v1.2][F12-B4] Loan Shark Tycoon [v1.3][F12-B4] Loan Shark Tycoon Mar 29, 2018
@jonleeyz
Copy link
Author

jonleeyz commented Apr 3, 2018

Hey @OuyangDanwen! Would there be a review of this PR for Milestone 1.3?

Otherwise, we will rename it soon to v1.4!

Thanks!

SoilChang pushed a commit to SoilChang/addressbook-level4 that referenced this pull request Apr 5, 2018
@jonleeyz jonleeyz changed the title [v1.3][F12-B4] Loan Shark Tycoon [v1.4][F12-B4] Loan Shark Tycoon Apr 6, 2018
@jonleeyz jonleeyz changed the title [v1.4][F12-B4] Loan Shark Tycoon [v1.4][F12-B4] LoanShark Tycoon Apr 6, 2018
@jonleeyz jonleeyz changed the title [v1.4][F12-B4] LoanShark Tycoon [v1.5][F12-B4] HuatAh! Apr 12, 2018
@jonleeyz jonleeyz changed the title [v1.5][F12-B4] HuatAh! [v1.5rc][F12-B4] HuatAh! Apr 12, 2018
melvintzw and others added 30 commits April 15, 2018 21:25
add tag references to FindCommandEnhancement, ModelTwo in PPP
Update PPP and documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants