Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly hash images based on contents and allow skipping generation of images #826

Open
wants to merge 17 commits into
base: v0
Choose a base branch
from

Conversation

jthawme
Copy link

@jthawme jthawme commented May 22, 2023

This is for nuxt 2 and recognise it may too much trouble to have merged in, but i wanted to open the PR in case it was useful for the core package, or the wider community

I patched the code so that it actually hashes the image based on the contents, not the filename, as that is more useful.

And on top of that, I've also added a method to the options to allow for skipping generation for files, couple with the contents hashing mentioned above, this becomes a very powerful method to speeding up build times potentially

The npm package of the fork is here, if anyone needs to use this functionality in their application
https://www.npmjs.com/package/jthawme-nuxt-image

@netlify
Copy link

netlify bot commented May 22, 2023

👷 Deploy request for nuxt-image-v1 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d8b06a6

@danielroe danielroe added the v0 label May 28, 2023
@danielroe danielroe changed the base branch from main to v0 May 28, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants