fixup: simplify #12
fixup: simplify #12
Conversation
ronag
force-pushed
the
transform-by-2
branch
7 times, most recently
from
ec7f248
to
b20d8ca
Compare
test/parallel/test-transform-by.js
Outdated
| transformByFuncReturnsObjectWithoutSymbolAsyncIterator(), | ||
| transformByEncoding(), | ||
| // NOTE: This doesn't make sense for iterable? Is it consistent with Readable.from? | ||
| // transformByEncoding(), |
There was a problem hiding this comment.
I'm not sure what this test, tests for?
There was a problem hiding this comment.
in order to have an analogue to (chunk, enc, cb) => { } we add an encoding property for cases where transform streams behave differently depending on the encoding.
There was a problem hiding this comment.
I don't think this is taken into account in Readable.from and since we are doing objectMode I'm still unsure what the semantics here should be. I need to think about this a bit more unless someone can clarify?
ronag
force-pushed
the
transform-by-2
branch
4 times, most recently
from
941e354
to
30bc1ad
Compare
ronag
force-pushed
the
transform-by-2
branch
7 times, most recently
from
c4235a4
to
134db8b
Compare
ronag
force-pushed
the
transform-by-2
branch
from
134db8b
to
62d6326
Compare
| } | ||
|
|
||
| Promise.all([ | ||
| transformBy(), | ||
| transformByFuncReturnsObjectWithSymbolAsyncIterator(), | ||
| transformByObjReturnedWSymbolAsyncIteratorWithNonPromiseReturningNext(), |
There was a problem hiding this comment.
@davidmarkclements: I don't think this test is needed. Returning a non promise is fine?
| iterator = iterable[SymbolIterator](); | ||
| else | ||
|
|
||
| if (!iterator || typeof iterator.next !== 'function') | ||
| throw new ERR_INVALID_ARG_TYPE('iterable', ['Iterable'], iterable); |
There was a problem hiding this comment.
@davidmarkclements Moved invalid arg check to Readable.from.
|
@davidmarkclements I've updated to include type checks |
|
@davidmarkclements: I don't understand the encoding test or implementation. Where else in streams related code do you see anything like this? Do you think you can explain it's purpose? |
ronag
force-pushed
the
transform-by-2
branch
3 times, most recently
from
5bf4f6e
to
4bfffea
Compare
Tries to simplify nodejs#28501