Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APPLE: add user agent details #1193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

APPLE: add user agent details #1193

wants to merge 1 commit into from

Conversation

rokas-ambrazevicius
Copy link
Contributor

@rokas-ambrazevicius rokas-ambrazevicius commented Sep 23, 2024 •
edited by mmsinclair
Loading

This change is Reviewable

octol
octol reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@octol octol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good to me. We need also the daemon version included in the version string, like in #1191. You can get the version from the info call

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @doums, @pronebird, and @zaneschepke)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octol octol octol left review comments

@pronebird pronebird Awaiting requested review from pronebird

@doums doums Awaiting requested review from doums

@zaneschepke zaneschepke Awaiting requested review from zaneschepke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokas-ambrazevicius @octol