-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a test for negative dates and see how onefetch handles it #1100
Conversation
Currently there is an 'empty' error which probably is related to a failure to parse commits with negative dates. This should be fixed in future versions of `gitoxide`.
Note that such repositories aren't easy to create in the first place and such pre-dated commits need to be created with tool-assistance. In any case, now `onefetch` is able to handle these as well.
It seems that the cache is getting in the way of even compiling successfully, and I don't know how to fix that. In theory, this PR already works and adds support for commits with early commit dates, so this repository could be visualized fi there was any code in it. Maybe that would also be an avenue of improvement for another day. |
Perhaps a call to |
A great idea, let me try that. GitHub also just had some general CI issues, I hope that's not interfering now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the CI is passing 🎉
Thanks a lot for the test, much better now! |
Currently there is an 'empty' error which probably is related to a failure to parse commits with negative dates.
This should be fixed in future versions of
gitoxide
.