Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHELC-1339] Port update_rhsm_custom_facts to Action framework #1299

Merged
merged 12 commits into from
Aug 19, 2024
Merged

[RHELC-1339] Port update_rhsm_custom_facts to Action framework #1299

merged 12 commits into from
Aug 19, 2024

Conversation

Andrew-ang9
Copy link
Contributor

@Andrew-ang9 Andrew-ang9 commented Jul 11, 2024 •
edited by pr-watson
Loading

This PR is a Port for update_rhsm_custom_facts function to the action framwork

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@r0x0d r0x0d mentioned this pull request Jul 15, 2024
Merged
8 tasks
@pr-watson pr-watson mentioned this pull request Aug 6, 2024
Closed
13 tasks
@Andrew-ang9 Andrew-ang9 force-pushed the port_update_RHSM_custom_facts branch from 05fc0ad to d3156b0 Compare August 7, 2024 18:59
@Andrew-ang9 Andrew-ang9 requested a review from a team as a code owner August 7, 2024 18:59
@Andrew-ang9 Andrew-ang9 force-pushed the port_update_RHSM_custom_facts branch from e848407 to b5d8307 Compare August 9, 2024 21:28
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.53%. Comparing base (e4b418f) to head (2a9609a).
Report is 1 commits behind head on main.

Files Patch % Lines
...ctions/post_conversion/rhsm_custom_facts_config.py 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
- Coverage   96.53%   96.53%   -0.01%     
==========================================
  Files          65       66       +1     
  Lines        4970     4986      +16     
  Branches      870      873       +3     
==========================================
+ Hits         4798     4813      +15     
  Misses         97       97              
- Partials       75       76       +1
Flag Coverage Δ
centos-linux-7 91.94% <93.75%> (+<0.01%) ⬆️
centos-linux-8 92.83% <93.75%> (+<0.01%) ⬆️
centos-linux-9 92.87% <93.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d force-pushed the port_update_RHSM_custom_facts branch from b5d8307 to 85a696a Compare August 14, 2024 13:10
@r0x0d r0x0d added enhancement New feature or request tests-run-sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Aug 14, 2024
@r0x0d r0x0d requested a review from a team August 14, 2024 13:10
@has-bot
Copy link
Member

has-bot commented Aug 14, 2024

/packit test --labels sanity

Comment generated by an automation.

@Andrew-ang9 Andrew-ang9 requested a review from a team as a code owner August 15, 2024 21:36
@kokesak
Copy link
Member

kokesak commented Aug 16, 2024

/packit test --labels sanity

Venefilyn
Venefilyn previously requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@Venefilyn Venefilyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments but unit tests are failing atm

convert2rhel/actions/post_conversion/rhsm_custom_facts_config.py Outdated Show resolved Hide resolved
convert2rhel/actions/post_conversion/rhsm_custom_facts_config.py Outdated Show resolved Hide resolved
convert2rhel/unit_tests/actions/post_conversion/rhsm_custom_facts_config_test.py Outdated Show resolved Hide resolved
convert2rhel/unit_tests/actions/post_conversion/rhsm_custom_facts_config_test.py Outdated Show resolved Hide resolved
convert2rhel/unit_tests/actions/post_conversion/rhsm_custom_facts_config_test.py Outdated Show resolved Hide resolved
@r0x0d
Copy link
Member

r0x0d commented Aug 19, 2024

/packit build

@pr-watson pr-watson force-pushed the port_update_RHSM_custom_facts branch from 32699e2 to a7d6cea Compare August 19, 2024 13:15
@pr-watson
Copy link
Contributor

/packit test --labels sanity

pr-watson
pr-watson approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@pr-watson pr-watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting on int tests

@pr-watson pr-watson force-pushed the port_update_RHSM_custom_facts branch from 0a0e208 to 196fbdc Compare August 19, 2024 14:38
@r0x0d
Copy link
Member

r0x0d commented Aug 19, 2024

/packit test --labels sanity

@pr-watson pr-watson force-pushed the port_update_RHSM_custom_facts branch from 196fbdc to 5de2274 Compare August 19, 2024 15:24
Andrew-ang9 and others added 12 commits August 19, 2024 11:38
@Andrew-ang9 @pr-watson
Draft port of update_rhsm_custom_facts
e58e9bb 
* Added to the draft for port of update_rhsm_custom_facts to
  post_conversion directory
* Added the corrisponding test for the port as well
@Andrew-ang9 @pr-watson
Moved the run() in the class for the port
c6d37fd 
* Removed unused imports
* Updated some of the names of the function
@Andrew-ang9 @pr-watson
Got the unit test passing
281c2b8 
* for the UpdateRHSMCustomFacts class added actions to the import
* removed the output var from the call to update_rhsm_custom_facts()
* added in the id,title,description,diagnosis
@Andrew-ang9 @pr-watson
Fixed the unit test for main_test and the action
d7155de 
* removed the mock for toolopts
* removed the diagnosis as it wasn't being used
* renamed the action and test to rhas_custom_facts_config and
  rhsm_custom_facts_config_test
@Andrew-ang9 @pr-watson
removed the import for toolopts as its not used
7e8bfeb
@Andrew-ang9 @pr-watson
Added an case for if there is no output
0519338
@Andrew-ang9 @pr-watson
Draft added a unit test for no output
586ce8b 
* added a log mesage for when there is no output
@Andrew-ang9 @pr-watson
Draft changed the unit test
6d5828d 
* this is being uploaded to check to see what is going on with
  pytest as its been returning a strange error even befor I made
  changes
@Andrew-ang9 @pr-watson
Changed the no_output test
919c9ca 
* this commit changes the way the rhsm_custom_facts_config_no_output()
  works and now we check for no output but just asserting the actions
  messages with an empty string
* Changed the RunSubprocessMocked() to use the exsisting one
@pr-watson
Apply suggestions from code review
649c469
@pr-watson
Update convert2rhel/unit_tests/actions/post_conversion/rhsm_custom_fa…
91d4d6a 
…cts_config_test.py
@pr-watson
Update convert2rhel/subscription.py
2a9609a
@pr-watson pr-watson force-pushed the port_update_RHSM_custom_facts branch from 5de2274 to 2a9609a Compare August 19, 2024 15:38
@pr-watson
Copy link
Contributor

/packit test --labels sanity

@r0x0d r0x0d linked an issue Aug 19, 2024 that may be closed by this pull request
Post Conversion Action Framework merge order #1331
Closed
13 tasks
@r0x0d r0x0d merged commit fc33f55 into oamg:main Aug 19, 2024
25 of 26 checks passed
r0x0d added a commit to r0x0d/convert2rhel that referenced this pull request Aug 19, 2024
@r0x0d
Fix couple of issues from last oamg#1299
60f3f68
r0x0d added a commit that referenced this pull request Aug 19, 2024
@r0x0d
Fix couple of issues from last #1299 (#1344)
f94ddd5
@pr-watson pr-watson changed the title [RHELC-1339] Port of update_rhsm_custom_facts [RHELC-1339] Port update_rhsm_custom_facts to Action framework Aug 21, 2024
This was referenced Aug 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0x0d r0x0d r0x0d left review comments

@pr-watson pr-watson pr-watson approved these changes

@Venefilyn Venefilyn Venefilyn left review comments

@danmyway danmyway Awaiting requested review from danmyway danmyway was automatically assigned from oamg/conversions-qe

Assignees
No one assigned
Labels
enhancement New feature or request tests-run-sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post Conversion Action Framework merge order
6 participants
@Andrew-ang9 @has-bot @kokesak @r0x0d @pr-watson @Venefilyn