Add support for using different tokens on ParaTimes #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/special-ticker-for-paratime
branch
from
a96fb2a
to
c99910b
Compare
csillag
force-pushed
the
csillag/special-ticker-for-paratime
branch
from
c99910b
to
e1d3ffd
Compare
This was referenced Feb 16, 2024
lubej
reviewed
Feb 16, 2024
csillag
force-pushed
the
csillag/special-ticker-for-paratime
branch
2 times, most recently
from
1c19e4b
to
bd8e8ad
Compare
|
Wait, let me adjust this so that we can support multiple tokens for paratimes... |
lubej
approved these changes
Feb 16, 2024
lubej
reviewed
Feb 16, 2024
csillag
force-pushed
the
csillag/special-ticker-for-paratime
branch
from
bd8e8ad
to
fa44b4c
Compare
lukaw3d
reviewed
Feb 16, 2024
csillag
force-pushed
the
csillag/special-ticker-for-paratime
branch
4 times, most recently
from
3a89941
to
30a6d9a
Compare
csillag
force-pushed
the
csillag/special-ticker-for-paratime
branch
2 times, most recently
from
62409af
to
d37cc87
Compare
Up to now, we assumed that the native token on each ParaTime is always the same as the native token on the network. Unfortunately this is not always true, so now we have to make it possible to use different tokens on paratimes.
- Rename a NativeTicker to Ticker - Add EUROe token (and logo) - Add metadata about known native tokens: - Ticker (symbol) - Is this a free token? - CoinGecko id - Generalize RosePriceCard to TokenPriceCard - Enhance layer token configuration - Describe the token, not the ticker - Support multiple tokens per layer - Define the tokens for the Pontus-X layer - CoinGecko: support pulling all wanted prices - Nexus API: - When loading data, observe the layer token configuration - Added RuntimeBalanceDisplay: a component for displaying balances in multiple tokens. - Added FiatMoneyAmount: a component for displaying fiat money value for balances in multiple tokens, summarizing value from all tokens. - ParaTimeSnapshot: display price/faucet for first token
The preferred fiat currency can now be configured per paratime / network.
csillag
force-pushed
the
csillag/special-ticker-for-paratime
branch
from
d37cc87
to
3520ce1
Compare
lukaw3d
reviewed
Feb 21, 2024
| isFree: !!token.free, | ||
| hasUsedCoinGecko: !!token.geckoId, | ||
| price: token.geckoId && geckoPrices ? (geckoPrices as any)[token.geckoId] : undefined, | ||
| fiatCurrency: token.geckoId && geckoPrices ? fiatCurrency : 'xx', |
There was a problem hiding this comment.
It should be an empty string. Anyway, since we don't have a price, the name of the currency will never be displayed.
There was a problem hiding this comment.
On second thought, we could simply use the provided fiatCurrency, too. It doesn't matter, since (missing the price) it won't be displayed.
Open
lukaw3d
reviewed
Feb 21, 2024
lukaw3d
reviewed
Feb 21, 2024
Comment on lines
753
to
+755
| paraTimesConfig[runtime].decimals, | ||
| ), | ||
| Denomination: getTickerForNetwork(network), | ||
| Denomination: getTokensForScope({ network, layer: runtime })[0].ticker, // TODO find this out from event data |
There was a problem hiding this comment.
We need to differentiate decimals based on denomination. If EUROe has the same number of decimals as TEST, that is only coincidentally and unreliable
There was a problem hiding this comment.
Yes, decimals are not yet solved. However this code has been updated later in #1279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, we assumed that the native token on each ParaTime is always the same as the native token on the network.
Unfortunately this is not always true, so now we have to make it possible to use different tokens on paratimes.