Small cleanups

.changelog/1285.trivial.md

@@ -0,0 +1 @@
+Various small cleanups

src/app/components/Balance/hooks.ts

@@ -3,9 +3,6 @@ import { AllTokenPrices } from '../../../coin-gecko/api'
 import BigNumber from 'bignumber.js'
 import { Ticker } from '../../../types/ticker'
 
-export const hasRuntimeBalance = (balances: RuntimeSdkBalance[] = []) =>
-  balances.some(balance => balance.token_decimals)
-
 export type FiatValueInfo = {
   /**
    * Do we have any known real value?

src/app/components/Snapshots/SnapshotCardExternalLink.tsx

@@ -21,13 +21,24 @@ type SnapshotCardExternalLinkProps = {
   label?: string
   title: string
   url?: string
+
+  /**
+   * Should we accept "mailto:" links?
+   *
+   * Those are more dangerous than other types, since they can
+   * facilitate displaying malicious URLs like javascript: and mailto:?attach=
+   *
+   * In order to prevent this, only enable this flag if we can be sure that the link is safe.
+   */
+  emailAccepted?: boolean
 }
 
 export const SnapshotCardExternalLink: FC<SnapshotCardExternalLinkProps> = ({
   description,
   label,
   title,
   url,
+  emailAccepted,
 }) => {
   return (
     <SnapshotCard title={title} withContentPadding={false}>
@@ -40,7 +51,7 @@ export const SnapshotCardExternalLink: FC<SnapshotCardExternalLinkProps> = ({
         >
           {description}
         </Typography>
-        {url && hasValidProtocol(url) && (
+        {url && (hasValidProtocol(url) || (emailAccepted && url.startsWith('mailto:'))) && (
           <Button href={url} target="_blank" rel="noopener noreferrer" color="secondary" variant="outlined">
             {label}
           </Button>

src/app/pages/ParatimeDashboardPage/TestnetFaucet.tsx

@@ -22,6 +22,7 @@ export const TestnetFaucet: FC<TestnetFaucetProps> = ({ network, layer, ticker }
       label={t('testnetFaucet.request')}
       title={t('testnetFaucet.header')}
       url={link}
+      emailAccepted={true}
     />
   ) : null
 }

src/app/pages/ValidatorDetailsPage/ExternalLinkCard.tsx

@@ -4,9 +4,19 @@ import { SnapshotCardExternalLink } from 'app/components/Snapshots/SnapshotCardE
 
 type ExternalLinkCardProps = {
   link?: string
+
+  /**
+   * Should we accept "mailto:" links?
+   *
+   * Those are more dangerous than other types, since they can
+   * facilitate displaying malicious URLs like javascript: and mailto:?attach=
+   *
+   * In order to prevent this, only enable this flag if we can be sure that the link is safe.
+   */
+  emailAccepted?: boolean
 }
 
-export const ExternalLinkCard: FC<ExternalLinkCardProps> = ({ link }) => {
+export const ExternalLinkCard: FC<ExternalLinkCardProps> = ({ link, emailAccepted }) => {
   const { t } = useTranslation()
 
   return (
@@ -15,6 +25,7 @@ export const ExternalLinkCard: FC<ExternalLinkCardProps> = ({ link }) => {
       label={link}
       title={t('validator.externalLink')}
       url={link}
+      emailAccepted={emailAccepted}
     />
   )
 }

src/app/utils/url.ts

@@ -1,4 +1,4 @@
-const validProtocols = ['http:', 'https:', 'ftp:', 'ipfs:', 'data:', 'mailto:']
+const validProtocols = ['http:', 'https:', 'ftp:', 'ipfs:', 'data:']
 
 export const hasValidProtocol = (url: string | undefined): boolean => {
   if (!url) {

src/coin-gecko/api.ts

@@ -82,7 +82,7 @@ export const useAllTokenPrices = (fiatCurrency: string): AllTokenPrices => {
       isFree: !!token.free,
       hasUsedCoinGecko: !!token.geckoId,
       price: token.geckoId && geckoPrices ? (geckoPrices as any)[token.geckoId] : undefined,
-      fiatCurrency: token.geckoId && geckoPrices ? fiatCurrency : 'xx',
+      fiatCurrency,
     }
   })
   return results

src/oasis-nexus/api.ts

@@ -748,13 +748,8 @@ export const useGetRuntimeEvents: typeof generated.useGetRuntimeEvents = (
                       event.body.amount.Denomination === ''
                         ? {
                             ...event.body.amount,
-                            Amount: fromBaseUnits(
-                              event.body.amount.Amount,
-                              paraTimesConfig[runtime].decimals,
-                            ),
-                            Denomination:
-                              event.body?.Denomination ??
-                              getTokensForScope({ network, layer: runtime })[0].ticker,
+                            Amount: fromBaseUnits(event.body.Amount, paraTimesConfig[runtime].decimals),
+                            Denomination: getTokensForScope({ network, layer: runtime })[0].ticker,
                           }
                         : event.body.amount,
                   },