Merge pull request #2040 from oasisprotocol/lw/table-expand

Fix expanding table rows on non-plaintext cell
oasisprotocol · Aug 19, 2024 · 296d8bd · 296d8bd
2 parents 799cd47 + 5a9214a
commit 296d8bd
Show file tree

Hide file tree

Showing 5 changed files with 223 additions and 136 deletions.
diff --git a/.changelog/2040.bugfix.md b/.changelog/2040.bugfix.md
@@ -0,0 +1 @@
+Fix expanding table rows on non-plaintext cell
diff --git a/...ngPage/Features/DelegationList/__tests__/__snapshots__/ActiveDelegationList.test.tsx.snap b/...ngPage/Features/DelegationList/__tests__/__snapshots__/ActiveDelegationList.test.tsx.snap
@@ -553,66 +553,76 @@ exports[`<ActiveDelegationList  /> should match snapshot 1`] = `
                 data-tag="allowRowEvents"
                 id="cell-icon-test-validator"
                 role="gridcell"
-              />
+              >
+                <div />
+              </div>
               <div
                 class="c16 c8 c17 rdt_TableCell"
                 data-tag="allowRowEvents"
                 id="cell-status-test-validator"
                 role="gridcell"
               >
-                <svg
-                  aria-label="Status is okay"
-                  class="c18"
-                  viewBox="0 0 24 24"
-                >
-                  <path
-                    d="M12 22c5.523 0 10-4.477 10-10S17.523 2 12 2 2 6.477 2 12s4.477 10 10 10zM7 12l4 3 5-7"
-                    fill="none"
-                    stroke="#000"
-                    stroke-width="2"
-                  />
-                </svg>
+                <div>
+                  <svg
+                    aria-label="Status is okay"
+                    class="c18"
+                    viewBox="0 0 24 24"
+                  >
+                    <path
+                      d="M12 22c5.523 0 10-4.477 10-10S17.523 2 12 2 2 6.477 2 12s4.477 10 10 10zM7 12l4 3 5-7"
+                      fill="none"
+                      stroke="#000"
+                      stroke-width="2"
+                    />
+                  </svg>
+                </div>
               </div>
               <div
                 class="c16 c9 c17 rdt_TableCell"
                 data-tag="allowRowEvents"
                 id="cell-name-test-validator"
                 role="gridcell"
               >
-                test-validator
+                <div>
+                  test-validator
+                </div>
               </div>
               <div
                 class="c16 c12 c17 rdt_TableCell"
                 data-tag="allowRowEvents"
                 id="cell-amount-test-validator"
                 role="gridcell"
               >
-                <span>
-                  <div
-                    class="c0"
-                    style="display: inline-flex; white-space: nowrap; font-family: "Roboto mono", monospace; letter-spacing: 0;"
-                  >
-                    0.00
-                  </div>
-                  <span
-                    class="c19"
-                  >
+                <div>
+                  <span>
+                    <div
+                      class="c0"
+                      style="display: inline-flex; white-space: nowrap; font-family: "Roboto mono", monospace; letter-spacing: 0;"
+                    >
+                      0.00
+                    </div>
                     <span
-                      class="notranslate"
-                      translate="no"
+                      class="c19"
                     >
-                       
+                      <span
+                        class="notranslate"
+                        translate="no"
+                      >
+                         
+                      </span>
                     </span>
                   </span>
-                </span>
+                </div>
               </div>
               <div
                 class="c16 c13 c17 rdt_TableCell"
                 data-tag="allowRowEvents"
                 id="cell-fee-test-validator"
                 role="gridcell"
               >
-                7%
+                <div>
+                  7%
+                </div>
               </div>
             </div>
           </div>

diff --git a/...age/Features/DelegationList/__tests__/__snapshots__/DebondingDelegationList.test.tsx.snap b/...age/Features/DelegationList/__tests__/__snapshots__/DebondingDelegationList.test.tsx.snap
@@ -560,49 +560,57 @@ exports[`<DebondingDelegationList  /> should match snapshot 1`] = `
                 data-tag="allowRowEvents"
                 id="cell-icon-test-validator+100"
                 role="gridcell"
-              />
+              >
+                <div />
+              </div>
               <div
                 class="c17 c9 c18 rdt_TableCell"
                 data-tag="allowRowEvents"
                 id="cell-name-test-validator+100"
                 role="gridcell"
               >
-                test-validator
+                <div>
+                  test-validator
+                </div>
               </div>
               <div
                 class="c17 c12 c18 rdt_TableCell"
                 data-tag="allowRowEvents"
                 id="cell-amount-test-validator+100"
                 role="gridcell"
               >
-                <span>
-                  <div
-                    class="c0"
-                    style="display: inline-flex; white-space: nowrap; font-family: "Roboto mono", monospace; letter-spacing: 0;"
-                  >
-                    0.00
-                  </div>
-                  <span
-                    class="c19"
-                  >
+                <div>
+                  <span>
+                    <div
+                      class="c0"
+                      style="display: inline-flex; white-space: nowrap; font-family: "Roboto mono", monospace; letter-spacing: 0;"
+                    >
+                      0.00
+                    </div>
                     <span
-                      class="notranslate"
-                      translate="no"
+                      class="c19"
                     >
-                       
+                      <span
+                        class="notranslate"
+                        translate="no"
+                      >
+                         
+                      </span>
                     </span>
                   </span>
-                </span>
+                </div>
               </div>
               <div
                 class="c17 c13 c18 rdt_TableCell"
                 data-tag="allowRowEvents"
                 id="cell-debondingTimeEnd-test-validator+100"
                 role="gridcell"
               >
-                <span>
-                  in 4 days
-                </span>
+                <div>
+                  <span>
+                    in 4 days
+                  </span>
+                </div>
               </div>
             </div>
           </div>