-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTR-substantia-nigra-dopaminergic-neuron-for-Basal-Ganglia-BICAN #2566
base: master
Are you sure you want to change the base?
Conversation
terms added: substantia nigra dopaminergic neuron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess not quite ready for review as lacks classification and location.
NOTE - clashing ID with https://github.com/obophenotype/cell-ontology/pull/2569/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good so far. See comments for what's still needed
@@ -32378,6 +32380,15 @@ SubClassOf(obo:CL_4042022 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_000101 | |||
SubClassOf(obo:CL_4042022 ObjectSomeValuesFrom(obo:RO_0002203 obo:CL_0000127)) | |||
SubClassOf(obo:CL_4042022 ObjectSomeValuesFrom(obo:RO_0002292 obo:PR_000001307)) | |||
|
|||
# Class: obo:CL_4042023 (substantia nigra dopaminergic neuron) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID CLASH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be resolved as the branch is merged.
AnnotationAssertion(Annotation(oboInOwl:SynonymTypeProperty obo:OMO_0003000) Annotation(oboInOwl:hasDbXref "PMID:32826893") oboInOwl:hasBroadSynonym obo:CL_4042023 "DaN") | ||
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:35308118") oboInOwl:hasNarrowSynonym obo:CL_4042023 "SNpc dopaminergic neuron") | ||
AnnotationAssertion(rdfs:label obo:CL_4042023 "substantia nigra dopaminergic neuron"@en) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classification, location etc still needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you be more specific?
the definition includes:
A midbrain dopaminergic neuron that has its soma located in a substantia nigra . This dopaminergic neuron type is highly metabolically active and it is involved in the regulation of movement, cognition, motivation and reward. Neurodegeneration of this dopaminergic neuronal type causes loss in fine motor control in Parkinson's Disease.
for classification see the most recent commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please split into two subCLassOf axioms. This is semantically identical, but some pipelines don't work well with subclassof X AND Y constructions.
AnnotationAssertion(Annotation(oboInOwl:SynonymTypeProperty obo:OMO_0003000) Annotation(oboInOwl:hasDbXref "PMID:32826893") oboInOwl:hasBroadSynonym obo:CL_4042023 "DaN") | ||
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:35308118") oboInOwl:hasNarrowSynonym obo:CL_4042023 "SNpc dopaminergic neuron") | ||
AnnotationAssertion(rdfs:label obo:CL_4042023 "substantia nigra dopaminergic neuron"@en) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please split into two subCLassOf axioms. This is semantically identical, but some pipelines don't work well with subclassof X AND Y constructions.
terms added: substantia nigra dopaminergic neuron