Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR-substantia-nigra-dopaminergic-neuron-for-Basal-Ganglia-BICAN #2566

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

AvolaAmg
Copy link
Collaborator

@AvolaAmg AvolaAmg commented Sep 16, 2024

terms added: substantia nigra dopaminergic neuron

terms added: substantia nigra dopaminergic neuron
@AvolaAmg AvolaAmg added this to the September release milestone Sep 16, 2024
@AvolaAmg AvolaAmg self-assigned this Sep 16, 2024
@AvolaAmg AvolaAmg changed the title NTR-for-Basal-Ganglia-BICAN NTR-substantia-nigra-dopaminergic-neuron-for-Basal-Ganglia-BICAN Sep 16, 2024
@AvolaAmg AvolaAmg added the HCA/DCP Needed/useful for the Human Cell Atlas label Sep 17, 2024
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not quite ready for review as lacks classification and location.

NOTE - clashing ID with https://github.com/obophenotype/cell-ontology/pull/2569/files

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far. See comments for what's still needed

@@ -32378,6 +32380,15 @@ SubClassOf(obo:CL_4042022 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_000101
SubClassOf(obo:CL_4042022 ObjectSomeValuesFrom(obo:RO_0002203 obo:CL_0000127))
SubClassOf(obo:CL_4042022 ObjectSomeValuesFrom(obo:RO_0002292 obo:PR_000001307))

# Class: obo:CL_4042023 (substantia nigra dopaminergic neuron)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID CLASH

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be resolved as the branch is merged.

AnnotationAssertion(Annotation(oboInOwl:SynonymTypeProperty obo:OMO_0003000) Annotation(oboInOwl:hasDbXref "PMID:32826893") oboInOwl:hasBroadSynonym obo:CL_4042023 "DaN")
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:35308118") oboInOwl:hasNarrowSynonym obo:CL_4042023 "SNpc dopaminergic neuron")
AnnotationAssertion(rdfs:label obo:CL_4042023 "substantia nigra dopaminergic neuron"@en)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classification, location etc still needed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be more specific?
the definition includes:

A midbrain dopaminergic neuron that has its soma located in a substantia nigra . This dopaminergic neuron type is highly metabolically active and it is involved in the regulation of movement, cognition, motivation and reward. Neurodegeneration of this dopaminergic neuronal type causes loss in fine motor control in Parkinson's Disease.

for classification see the most recent commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please split into two subCLassOf axioms. This is semantically identical, but some pipelines don't work well with subclassof X AND Y constructions.

AnnotationAssertion(Annotation(oboInOwl:SynonymTypeProperty obo:OMO_0003000) Annotation(oboInOwl:hasDbXref "PMID:32826893") oboInOwl:hasBroadSynonym obo:CL_4042023 "DaN")
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:35308118") oboInOwl:hasNarrowSynonym obo:CL_4042023 "SNpc dopaminergic neuron")
AnnotationAssertion(rdfs:label obo:CL_4042023 "substantia nigra dopaminergic neuron"@en)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please split into two subCLassOf axioms. This is semantically identical, but some pipelines don't work well with subclassof X AND Y constructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BICAN HCA/DCP Needed/useful for the Human Cell Atlas new term request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants