Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps.windows: Add VPL debug library #205

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Aug 5, 2023

Description

deps.windows: Install VPL Debug library if present

Also clean up some stray whitespace.

CI: Add VPL Debug build

Similar to AJA's NTV2 library, it seems that VPL requires a separate Debug library to be able to build OBS Studio in Debug with VPL. Use the same technique that we used for NTV2 for VPL.

Motivation and Context

Want to be able to build OBS Studio in Debug with QSV+VPL enabled.

How Has This Been Tested?

Tested locally on Windows 11 by building the VPL dependency in Debug and then building OBS Studio in Debug with a VPL enabled branch.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Also clean up some stray whitespace.
Similar to AJA's NTV2 library, it seems that VPL requires a separate
Debug library to be able to build OBS Studio in Debug with VPL. Use the
same technique that we used for NTV2 for VPL.
@RytoEX RytoEX added the enhancement New feature or request label Aug 5, 2023
@RytoEX RytoEX requested a review from PatTheMav August 5, 2023 01:41
@RytoEX RytoEX self-assigned this Aug 5, 2023
@RytoEX RytoEX changed the title Add VPL debug lib deps.windows: Add VPL debug library Aug 7, 2023
@RytoEX RytoEX merged commit c9b91ab into obsproject:master Aug 7, 2023
22 checks passed
@RytoEX RytoEX deleted the add-vpl-debug-lib branch August 7, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant