Clean up old PowerShell code #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerShell 7.0 has not been supported by Microsoft since December 2022. GitHub Actions uses PowerShell 7.2, and we do not recommend anything older than that. Let's enforce that recommendation with the runtime version check.
The main build script has required PowerShell 7 for some time now, and it will exit early without it, so we no longer need to handle cases for older versions such as PowerShell 5 or 6.
PatTheMav
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove code branches that handled versions of PowerShell older than PowerShell 7.0 (such as PowerShell 5.x and 6.x, or Desktop vs. Core). Increase the minimum required PowerShell version from 7.0 to 7.2 since 7.0 is no longer supported.
Motivation and Context
PowerShell 7.2 is the currently supported LTS version of PowerShell and is available on all GitHub Actions runner images. Let's shed a tiny bit of code that we don't need anymore.
How Has This Been Tested?
Tested locally on Windows 11.
Types of changes
Checklist: