[ADD] Appraisals: Appraisal Analysis reporting #11037
Conversation
|
|
|
Hi @Felicious - this is ready for a review! |
There was a problem hiding this comment.
Amazing job with this new reporting doc, @larm-odoo !
Your doc is concise and easy to read and follow. It's also well-researched and I can tell you put in effort to find these various groups and filters. I just had very minor rewording suggestions, and after that, feel free to move this onto final review.
Thank you for giving me the chance to review docs again ❤️
larm-odoo
force-pushed
the
17.0-appraisals-new-appraisal-analysis-larm
branch
from
da8e45a
to
e3d9466
Compare
|
Hi @ksc-odoo - this is ready for a final review! |
There was a problem hiding this comment.
hey @larm-odoo -- just finished my Final Review. Nice job! Only have a handful of minor comments/suggestions that require your attention. Once you address those, and implement the necessary changes, feel free to tag this for Tech Review. Thanks! 👍
larm-odoo
force-pushed
the
17.0-appraisals-new-appraisal-analysis-larm
branch
from
e3d9466
to
9561821
Compare
|
Hi @jero-odoo - this is ready for a final review. Thanks! |
There was a problem hiding this comment.
Hey @larm-odoo great work on this doc! Overall, everything looked great but a few things need to be fixed before this can be merged.
-Please delete all of the unused images from the image folder (I believe there are five extras in there)
- Double check that the image users-appraisals.png has been compressed through pngquant
-There needs to be a redirect for the old "reporting" doc, it doesn't appear that there is. Can you please add it?
Let me know if you have any questions, thank you!
larm-odoo
force-pushed
the
17.0-appraisals-new-appraisal-analysis-larm
branch
from
9561821
to
d71c876
Compare
|
Thanks @jero-odoo - when I made the new file, I didn't realize the old images were in there, and I also forgot the redirect! Everything should be in order if you want to take another look. |
|
Looks good @larm-odoo thanks! Sending to @StraubCreative for merge |
|
@robodoo r+ |
closes #11037 Signed-off-by: Zachary Straub (zst) <[email protected]>
closes #11037 Signed-off-by: Zachary Straub (zst) <[email protected]>
|
@larm-odoo @StraubCreative staging failed: ci/runbot on bee603a7671353e808ccb0250242e60be8ba71b6 (view more at https://runbot.odoo.com/runbot/build/68483212) |
Original reporting doc covered both reports. There is now a Skills Analysis PR being reviewed, and this PR is to make the Appraisal Analysis report. The original "reportng.rst" file is being deleted.
Original task card for this PR.