Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] studio: complete update of Studio #1974

Closed
wants to merge 1 commit into from

Conversation

xpl-odoo
Copy link
Contributor

@xpl-odoo xpl-odoo commented May 9, 2022

The goal is to make the Studio users doc a sort of encyclopedia to accompany tutorials.
The doc isn't to explain the basics - or just briefly, as introductions - but instead to
give a full overview of all the available options.

Task: 2817981

@xpl-odoo xpl-odoo requested a review from Donapi May 9, 2022 14:46
@robodoo
Copy link
Collaborator

robodoo commented May 9, 2022

@C3POdoo C3POdoo requested a review from a team May 9, 2022 14:48
@xpl-odoo xpl-odoo removed the request for review from a team May 10, 2022 08:04
@xpl-odoo xpl-odoo force-pushed the 15.0-studio-complete-update-xpl branch 2 times, most recently from 6996f5d to d349cfc Compare May 10, 2022 09:35
Copy link
Contributor

@Donapi Donapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Xavier!!

@odoo odoo deleted a comment from Donapi May 23, 2022
@xpl-odoo xpl-odoo force-pushed the 15.0-studio-complete-update-xpl branch 2 times, most recently from 5974f28 to 562e6ac Compare May 23, 2022 09:24
@xpl-odoo xpl-odoo requested a review from Donapi May 23, 2022 09:25
@xpl-odoo xpl-odoo requested a review from jcs-odoo May 25, 2022 08:48
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @xpl-odoo and @Donapi

Excellent work, it's impressive :)
Please have a look at the comments (and please split your work in multiple PRs :D )

  • no image at all is maybe a bit harsh. While it's best not to have too many images for no good reason, some contextual illustrations and schematics (such as the relational fields (or a simplified version of it)) could help the users, imo. Especially when you present new unknown screens like you do in most of these pages. (it's not the usual menuselection as the rest of the apps)
  • make sure to use only one type of apostrophe. (I have a preference for the straight ' instead of the curly one) (pro tip, use ctrl+r to replace easily in Pycharm, and ctrl+shift+r to do the same in multiple documents at once)
  • no mention of the deleted rainbow man file? :D (kidding)

Cheers,
Jonathan

content/applications/productivity/studio.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/fields.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/fields.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/fields.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/fields.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/views.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/views.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/views.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/views.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/views.rst Outdated Show resolved Hide resolved
@xpl-odoo xpl-odoo force-pushed the 15.0-studio-complete-update-xpl branch 2 times, most recently from 6870cda to d68fd4f Compare July 1, 2022 15:43
@xpl-odoo xpl-odoo requested a review from jcs-odoo July 1, 2022 15:43
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a beautiful work you've done @xpl-odoo !

I couldn't reread it fully in-depth as I wanted, but overall, it seems really great :)

I really like the addition of images, although I'm a bit concerned by their sizes. But, IMO, it's worth it. Can you have a look at the ones above 60ko, though, especially the map-task one? Maybe a jpeg would handle this better, but do we want that, @AntoineVDV ? Or simply downscale it slightly and set a quality option on pngquant (I could lower it to 200ko by defining a quality of 5-10% and it still looks great actually!

You'll have to rebase your branch as I explained in my mail yesterday, though.

Ping doc-review once it's ready, as I won't be able to do it myself.

Cheers, and congratulations for this awesome work :)

content/applications/productivity/studio.rst Outdated Show resolved Hide resolved
@xpl-odoo xpl-odoo force-pushed the 15.0-studio-complete-update-xpl branch from d68fd4f to d509124 Compare July 22, 2022 08:30
@xpl-odoo xpl-odoo requested review from AntoineVDV and a team and removed request for AntoineVDV July 22, 2022 08:33
content/applications/productivity/studio.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/fields.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/fields.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/fields.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/fields.rst Outdated Show resolved Hide resolved
content/applications/productivity/studio/views.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove models_modules_apps/custom-sorting.png now that it's no longer used.

content/applications/productivity/studio/views.rst Outdated Show resolved Hide resolved
The goal is to make the Studio users doc a sort of encyclopedia to accompany tutorials.
The doc isn't to explain the basics - or just briefly, as introductions - but instead to
give a full overview of all the available options.

Task: 2817981
@xpl-odoo xpl-odoo force-pushed the 15.0-studio-complete-update-xpl branch from 5091a71 to 598f07b Compare July 27, 2022 15:00
@xpl-odoo xpl-odoo requested a review from AntoineVDV July 27, 2022 15:01
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request Jul 28, 2022
The goal is to make the Studio users doc a sort of encyclopedia to accompany tutorials.
The doc isn't to explain the basics - or just briefly, as introductions - but instead to
give a full overview of all the available options.

closes #1974

Task: 2817981
Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
@robodoo robodoo closed this Jul 28, 2022
@robodoo robodoo temporarily deployed to merge July 28, 2022 08:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants