-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] studio: complete update of Studio #1974
Conversation
6996f5d
to
d349cfc
Compare
content/applications/productivity/studio/models_modules_apps.rst
Outdated
Show resolved
Hide resolved
content/applications/productivity/studio/models_modules_apps.rst
Outdated
Show resolved
Hide resolved
content/applications/productivity/studio/models_modules_apps.rst
Outdated
Show resolved
Hide resolved
content/applications/productivity/studio/models_modules_apps.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job Xavier!!
5974f28
to
562e6ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @xpl-odoo and @Donapi
Excellent work, it's impressive :)
Please have a look at the comments (and please split your work in multiple PRs :D )
- no image at all is maybe a bit harsh. While it's best not to have too many images for no good reason, some contextual illustrations and schematics (such as the relational fields (or a simplified version of it)) could help the users, imo. Especially when you present new unknown screens like you do in most of these pages. (it's not the usual menuselection as the rest of the apps)
- make sure to use only one type of apostrophe. (I have a preference for the straight
'
instead of the curly one) (pro tip, use ctrl+r to replace easily in Pycharm, and ctrl+shift+r to do the same in multiple documents at once) - no mention of the deleted rainbow man file? :D (kidding)
Cheers,
Jonathan
6870cda
to
d68fd4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a beautiful work you've done @xpl-odoo !
I couldn't reread it fully in-depth as I wanted, but overall, it seems really great :)
I really like the addition of images, although I'm a bit concerned by their sizes. But, IMO, it's worth it. Can you have a look at the ones above 60ko, though, especially the map-task one? Maybe a jpeg would handle this better, but do we want that, @AntoineVDV ? Or simply downscale it slightly and set a quality option on pngquant (I could lower it to 200ko by defining a quality of 5-10% and it still looks great actually!
You'll have to rebase your branch as I explained in my mail yesterday, though.
Ping doc-review once it's ready, as I won't be able to do it myself.
Cheers, and congratulations for this awesome work :)
d68fd4f
to
d509124
Compare
content/applications/productivity/studio/models_modules_apps.rst
Outdated
Show resolved
Hide resolved
content/applications/productivity/studio/models_modules_apps.rst
Outdated
Show resolved
Hide resolved
content/applications/productivity/studio/models_modules_apps.rst
Outdated
Show resolved
Hide resolved
d509124
to
5091a71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to remove models_modules_apps/custom-sorting.png
now that it's no longer used.
The goal is to make the Studio users doc a sort of encyclopedia to accompany tutorials. The doc isn't to explain the basics - or just briefly, as introductions - but instead to give a full overview of all the available options. Task: 2817981
5091a71
to
598f07b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
The goal is to make the Studio users doc a sort of encyclopedia to accompany tutorials. The doc isn't to explain the basics - or just briefly, as introductions - but instead to give a full overview of all the available options. closes #1974 Task: 2817981 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
The goal is to make the Studio users doc a sort of encyclopedia to accompany tutorials.
The doc isn't to explain the basics - or just briefly, as introductions - but instead to
give a full overview of all the available options.
Task: 2817981