Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/#133] 교재 추가 서비스 수정 #136

Merged
merged 3 commits into from
Aug 15, 2023
Merged

[Fix/#133] 교재 추가 서비스 수정 #136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52325f2
feat : 교재 추가 시 오답노트 생성 수정
linirini Aug 14, 2023
cac1cab
Merge branch 'feature-classroom' into fix/#133
linirini Aug 15, 2023
798f9af
fix : spotless
linirini Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/main/java/com/ohdab/classroom/service/AddWorkbookService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import com.ohdab.workbook.domain.workbookid.WorkbookId;
import com.ohdab.workbook.repository.WorkbookRepository;
import java.util.List;
import java.util.stream.Collectors;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
Expand Down Expand Up @@ -59,14 +60,15 @@ private Workbook saveWorkbook(

private void saveMistakeNote(long classroomId, WorkbookId workbookId) {
List<StudentId> studentIdList = classroomRepository.findStudentsById(classroomId);
studentIdList.forEach(
studentId -> {
MistakeNote mistakeNote =
MistakeNote.builder()
.studentId(studentId)
.workbookId(workbookId)
.build();
mistakeNoteRepository.save(mistakeNote);
});
List<MistakeNote> mistakeNoteList =
studentIdList.stream()
.map(
studentId ->
MistakeNote.builder()
.studentId(studentId)
.workbookId(workbookId)
.build())
.collect(Collectors.toList());
mistakeNoteRepository.saveAll(mistakeNoteList);
}
}
3 changes: 1 addition & 2 deletions src/test/java/com/ohdab/classroom/service/AddWorkbookServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import static org.assertj.core.api.Assertions.assertThatNoException;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.when;

import com.ohdab.classroom.domain.Classroom;
Expand Down Expand Up @@ -83,6 +82,6 @@ public class AddWorkbookServiceTest {
addWorkbookUsecase.addWorkbookByClassroomId(
classroomId, addWorkbookDto));
assertThat(classroom.getWorkbooks().size()).isEqualTo(workbookId);
Mockito.verify(mistakeNoteRepository, times(studentIdList.size())).save(Mockito.any());
Mockito.verify(mistakeNoteRepository).saveAll(Mockito.any());
}
}
Loading