Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default permission class to IsAuthenticated & made required changes #2268

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Set default permission class to IsAuthenticated & made required changes #2268

wants to merge 2 commits into from
+68 −111

Conversation

dhruv-goyal-10
Copy link
Contributor

Fixes #2238

Proposed Changes

  • set permissions to [] on required public endpoints
  • removed explicit permission attribute if it IsAuthenticated only

Associated Issue

Architecture changes

  • Added IsAuthenticated as default permission class in settings file

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@dhruv-goyal-10
Set default permission class to IsAuthenticated & made required changes
8628bbe 
set permissions to [] on required public endpoints

removed explicit permission attribute if it IsAuthenticated only

Fixes ohcnetwork#2238
@dhruv-goyal-10 dhruv-goyal-10 requested a review from a team as a code owner June 17, 2024 14:35
@dhruv-goyal-10
Copy link
Contributor Author

@sainak Can you have a look at this PR?

@vigneshhari
Copy link
Member

@sainak Functional review required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default permission class to IsAuthenticated
2 participants
@dhruv-goyal-10 @vigneshhari